Skip to content

[FIX] Fixed #261. Retryable Job Exception must also throw the excepti… #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agent-z28 wants to merge 2 commits into from
Closed

[FIX] Fixed #261. Retryable Job Exception must also throw the excepti… #308

agent-z28 wants to merge 2 commits into from

Conversation

@agent-z28
Copy link

@agent-z28 agent-z28 commented Feb 6, 2021

…on and rollback

Backport from ca2af15

@guewen
Copy link
Member

guewen commented Feb 8, 2021

Thanks! Could you fix the travis build please? It complains about the lint.

@guewen
Copy link
Member

guewen commented Feb 10, 2021

@agenterp I modified the change on #312 and #311, could you include it in your backport please?

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Mar 12, 2021

@agenterp what do you think of the original PRs? Can you review them, and if you agree with the changes, update this PR?

@agent-z28
Copy link
Author

agent-z28 commented Mar 25, 2021

@agenterp what do you think of the original PRs? Can you review them, and if you agree with the changes, update this PR?

@StefanRijnhart yes i can take care now

Fix date_done set when state changes back to pending
5ca07fc 
When Job.date_done has been set, for instance because the job has been
performed, if the job is set back to pending (e.g. a RetryableJobError
is raised), the date_done is kept
@github-actions
Copy link

github-actions bot commented Mar 20, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 20, 2022
@github-actions github-actions bot closed this Apr 24, 2022
@StefanRijnhart
Copy link
Member

StefanRijnhart commented May 14, 2022

Sorry for the delay. Thanks for taking the last change from the other PR. Now, about this PR: the diff looks different from the other PRs, I believe because you seem to be taking other changes as well, such as b511c3a. If that is the case, can you update your branch and cherry pick these commits so that authorship and history is preserved?

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 14, 2022

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 15, 2022
@github-actions
Copy link

github-actions bot commented Sep 18, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 18, 2022
@github-actions github-actions bot closed this Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agent-z28 @guewen @StefanRijnhart @OCA-git-bot