-
-
Notifications
You must be signed in to change notification settings - Fork 535
[13.0] Fix missing rollback on retried jobs #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is an issue because the job has a |
Fixed by the last commit, not a new thing. |
|
However, the |
When RetryableJobError was raised, any change done by the job was not rollbacked. Using `raise` would throw the exception up to the core and rollback, but we would have a stack trace in the logs for each try. Calling rollback manually (rollback also clears the env) hide the tracebacks, however, when the last try fails, the full traceback is still shown in the logs. Fixes #261
When Job.date_done has been set, for instance because the job has been performed, if the job is set back to pending (e.g. a RetryableJobError is raised), the date_done is kept.
d37f40c to
b42945f
Compare
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at f707889. Thanks a lot for contributing to OCA. ❤️ |
Port from #284 / #311
When RetryableJobError was raised, any change done by the job was not
rollbacked.
Using
raisewould throw the exception up to the core and rollback, butwe would have a stack trace in the logs for each try. Calling rollback
manually (rollback also clears the env) hide the tracebacks, however,
when the last try fails, the full traceback is still shown in the logs.
Fixes #261