[18.0][FIX] repair_type: location_id is now computed #111
Conversation
AaronHForgeFlow
force-pushed
the
18.0-fix-repair_type-tests
branch
from
a0c31ff to
c64812d
Compare
| move.repair_line_type | ||
| ) | ||
| move.location_id = location_src | ||
| move.location_dest_id = location_dest |
There was a problem hiding this comment.
shouldn't the location dest id be changed in the compute method compute_location_dest_id from standard?
There was a problem hiding this comment.
🤔 yes, let me check
There was a problem hiding this comment.
You are right! I did the change :)
AaronHForgeFlow
changed the title
repair_type/models/stock_move.py
Outdated
| move.location_id = location_src | ||
| move.location_dest_id = location_dest | ||
| else: | ||
| res = super()._compute_location_id() |
There was a problem hiding this comment.
I think this is also not correct, you are doing super for the whole recordset on every iteration. The odoo approach can inspire you odoo/odoo@6aee84e#diff-ff31dd528a40b4d1e4dffeabce24c78b96deb6576802956f532eaaeb9826cbd8R257
There was a problem hiding this comment.
good point! It is fixed now. Thanks for the example!
AaronHForgeFlow
force-pushed
the
18.0-fix-repair_type-tests
branch
from
c64812d to
9211428
Compare
odoo/odoo@6aee84e It is needed to override the compute method or type locations are not used
AaronHForgeFlow
force-pushed
the
18.0-fix-repair_type-tests
branch
from
9211428 to
7070fbb
Compare
|
@JordiMForgeFlow could you update your review? |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 42b916f. Thanks a lot for contributing to OCA. ❤️ |
4 participants
Test are failing in 18.0 branch⚠️
This commit odoo/odoo@6aee84e seems to make repair_type locations not to be used.