Skip to content

Conversation

@BhaveshHeliconia
Copy link
Contributor

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Jan 7, 2025
10 tasks
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-repair_service branch from 4f26979 to 9ed88bd Compare January 7, 2025 12:44
Copy link
Contributor

@AndreuOForgeFlow AndreuOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code and functional review 👍

Copy link
Contributor

@LauraCForgeFlow LauraCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LG!

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @AaronHForgeFlow you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@AaronHForgeFlow
Copy link
Contributor

Hi I think this can be merged!

I created this PR for an improvement: HeliconiaIO#1 but that one can be proposed after merging this one. Thank you.

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-82-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 24, 2025
Signed-off-by LoisRForgeFlow
@OCA-git-bot
Copy link
Contributor

@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-82-by-LoisRForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@LoisRForgeFlow
Copy link
Contributor

#111 needs to be addressed first.

@AaronHForgeFlow
Copy link
Contributor

Hi @BhaveshHeliconia, OCA/18.0 is now green. Can you please rebase your branch?

@LoisRForgeFlow
Copy link
Contributor

We can try to mergea again, the bot will take care of rebasing.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-82-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d99ad44 into OCA:18.0 Jul 24, 2025
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b4138ff. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration repair_service

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants