[12.0][MIG] onchange helper #1461

sbejaoui · 2018-12-17T14:45:47Z

No description provided.

onchange_helper/models/base.py

lmignon

Thank you @sbejaoui LGTM (Code review only)

onchange_helper/readme/CONTRIBUTORS.rst

other improvement: set onchange_specs to all fields as _onchange_spec() retrun onchange fields for default view return field value if it's set in onchange_fields (usuful to get default value for a field)

sbejaoui

@lmignon , I pushed some changes. can you check them please.

lmignon · 2018-12-18T16:58:21Z

@astirpe @sebastienbeau @florian-dacosta Could you take a look to the two last commits PLZ?
a22f10e
0f4f8bb
These changes looks to me very useful and should be back ported into previous versions IMO.

lmignon · 2019-01-28T09:32:59Z

onchange_helper/models/base.py

+        return {
+            f: v
+            for f, v in all_values.items()
+            if not self._fields[f].compute


@sbejaoui You should take a look at https://github.com/OCA/server-tools/pull/1484/files

done, thanks :)

…e values

lmignon · 2019-01-29T09:06:20Z

onchange_helper/models/base.py

+            # We get default values, they may be used in onchange
+            record_values = self.default_get(self._fields.keys())
+        for field in self._fields:
+            if field not in all_values:


@sbejaoui Do you remember the motivations behind the lines from 55 to 56? IMO we must exclude non stored fields. I observe that if I put all the fields of my model, my non stored fields are recomputed even if not accessed by an onchange...

We try to get values from existing record or defaults one to fill missing data in all_values passed to play_onchange.

server-tools/onchange_helper/models/base.py

Lines 43 to 50 in 176916f

if self:

self.ensure_one()

record_values = self._convert_to_write(

{

field_name: self[field_name]

for field_name, field in self._fields.items()

}

)

IMO, field_name: self[field_name] trigger the compute process.

But do we really need all values.... We should let the ORM compute the one required once accessed. In my case, these lines trigger the compute of useless field and cause performance issue.

I think we can exclude computed fields.

I've the same feeling.

bealdav · 2019-02-27T11:21:33Z

Hi, thanks for your work.

I have a use case that doesn't work with this code.

Float fields with a value of 0.0 is evaluated to False and then is not returned to vals

It's is not easy to reproduce with unit tests on res.partner.

My case :

I import csv of purchase line with only specified product_id and qty

I want this onchange played called by onchange_product_id()
https://github.com/odoo/odoo/blob/339bf145ced6fb30f10d6d2941cfdaadf594d426/addons/purchase/models/purchase.py#L630

vals = self.env['purchase.order.line'].play_onchanges(vals, ['product_id'])

price_unit is equal to 0.0, and don't reach vals but is mandatory for purchase lines.

I'll investigate deeper.

lmignon · 2019-02-27T17:17:57Z

@bealdav I'm refactoring this module in V10 to improve the performances... In the same time I'm adding a lot of tests. I've a corner case that doesn't pass the tests (recursive onchange on on2many relation). I'll also add a test for this UC to see if the new code is more robust. https://github.com/OCA/server-tools/pull/1510/files

bealdav · 2019-02-27T17:21:42Z

@lmignon thanks a lot

njeudy

Just install and test on a copy of a prod database.

Ok for me it works as needed !

OCA-git-bot · 2019-05-03T13:37:10Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2019-05-13T12:32:03Z

@OCA/core-maintainers

Syncing from upstream OCA/server-tools (15.0)

florian-dacosta and others added 7 commits December 17, 2018 15:37

Add onchange_helper module

07d9f3e

[MIG] module onchange_helper to v10.0

d92f334

[FIX] avoid a crash when value is False for a M2O field

e681d9b

OCA Transbot updated translations from Transifex

fe19685

[11.0][MIG] onchange_helper + add tests

1c0b7b9

OCA Transbot updated translations from Transifex

97342a2

[UPD] Update onchange_helper.pot

5f8f1a0

sbejaoui force-pushed the 12.0-mig-onchange_helper branch from 840c2b1 to d8fd6ed Compare December 17, 2018 14:46

pedrobaeza added this to the 12.0 milestone Dec 17, 2018

OCA-git-bot mentioned this pull request Dec 17, 2018

Migration to version 12.0 #1368

Closed

32 tasks

sbejaoui added 2 commits December 17, 2018 16:12

[12.0][MIG] - onchange_helper migration to 12.0

3406030

[ADD] setup.py

68b0591

sbejaoui force-pushed the 12.0-mig-onchange_helper branch from 1ed501c to 68b0591 Compare December 17, 2018 15:12

sebastienbeau and others added 2 commits December 17, 2018 18:37

[FWP] - Forward porting changes from OCA#1253

7e5ce25

[IMP] - Adapt unit tests

a728a29

sbejaoui force-pushed the 12.0-mig-onchange_helper branch from 5c318a1 to a132f3e Compare December 17, 2018 18:33

[IMP] - read may be harmful to performance

a22f10e

sbejaoui force-pushed the 12.0-mig-onchange_helper branch from a132f3e to a22f10e Compare December 17, 2018 18:34

sbejaoui commented Dec 17, 2018

View reviewed changes

onchange_helper/models/base.py Show resolved Hide resolved

sbejaoui changed the title ~~[12.0][WIP][MIG] onchange helper~~ [12.0][MIG] onchange helper Dec 17, 2018

lmignon approved these changes Dec 18, 2018

View reviewed changes

onchange_helper/readme/CONTRIBUTORS.rst Show resolved Hide resolved

[IMP] - get default values for non record onchange call

0f4f8bb

other improvement: set onchange_specs to all fields as _onchange_spec() retrun onchange fields for default view return field value if it's set in onchange_fields (usuful to get default value for a field)

sbejaoui commented Dec 18, 2018

View reviewed changes

sbejaoui force-pushed the 12.0-mig-onchange_helper branch from 056b070 to 424ae0a Compare December 20, 2018 09:30

[UPD] - Update documentation

cf21042

sbejaoui force-pushed the 12.0-mig-onchange_helper branch from 424ae0a to cf21042 Compare December 20, 2018 09:31

sbejaoui mentioned this pull request Jan 21, 2019

[FIX] don't remove computed fields with inverse method of the onchange values #1484

Merged

lmignon reviewed Jan 28, 2019

View reviewed changes

[FIX] don't remove computed fields with inverse method of the onchang…

176916f

…e values

lmignon mentioned this pull request Jan 28, 2019

[10.0] onchange_helper: backport enhancements from 12.0 #1488

Closed

lmignon reviewed Jan 29, 2019

View reviewed changes

PierrickBrun mentioned this pull request Feb 14, 2019

[12.0] MIG quick purchase OCA/purchase-workflow#653

Merged

astirpe mentioned this pull request Apr 4, 2019

[12.0][MIG] sale_order_import OCA/edi#101

Merged

2 tasks

njeudy approved these changes May 3, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels May 3, 2019

ThomasBinsfeld approved these changes May 8, 2019

View reviewed changes

rousseldenis mentioned this pull request May 13, 2019

[12.0][MIG] shopinvader shopinvader/odoo-shopinvader#320

Merged

8 tasks

lmignon merged commit 59714c4 into OCA:12.0 May 14, 2019

lmignon deleted the 12.0-mig-onchange_helper branch May 14, 2019 07:21

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#1461 from OCA/15.0

9a0a0d3

Syncing from upstream OCA/server-tools (15.0)

	if self:
	self.ensure_one()
	record_values = self._convert_to_write(
	{
	field_name: self[field_name]
	for field_name, field in self._fields.items()
	}
	)

Uh oh!

[12.0][MIG] onchange helper #1461

[12.0][MIG] onchange helper #1461

Uh oh!

Conversation

sbejaoui commented Dec 17, 2018

Uh oh!

Uh oh!

lmignon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sbejaoui left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmignon commented Dec 18, 2018

Uh oh!

lmignon Jan 28, 2019

Choose a reason for hiding this comment

Uh oh!

sbejaoui Jan 28, 2019

Choose a reason for hiding this comment

Uh oh!

lmignon Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

sbejaoui Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

lmignon Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

sbejaoui Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

lmignon Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

bealdav commented Feb 27, 2019

Uh oh!

lmignon commented Feb 27, 2019

Uh oh!

bealdav commented Feb 27, 2019

Uh oh!

njeudy left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 3, 2019

Uh oh!

rousseldenis commented May 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

sbejaoui left a comment •

edited

Loading