[FIX] don't remove computed fields with inverse method of the onchange values #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Contributor
|
LGTM, I will forward-port it to #1461 after merge. |
sbejaoui
approved these changes
Jan 21, 2019
bealdav
approved these changes
Jan 22, 2019
chafique-delli
approved these changes
Jan 22, 2019
chafique-delli
left a comment
chafique-delli
left a comment
There was a problem hiding this comment.
@bguillot , Thank you for this fix.
mourad-ehm
approved these changes
Jan 22, 2019
alexis-via
approved these changes
Jan 22, 2019
Contributor
|
This PR has the |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (9.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes an issue in onchange_helper module.
Current behavior :
If you want to write a computed field with inverse method and call the method play_onchanges, it will be removed of the returned dict.
Expected behavior :
Computed fields are removed from the values dictionnary unless the field has a inverse method