[16.0][FIX] auto_backup: do not fail if directory exists #2939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirAionTech
suggested changes
May 28, 2024
SirAionTech
left a comment
SirAionTech
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Only code review
NL66278
force-pushed
the
16.0-fix-auto_backup
branch
from
ad8d63b to
360fd41
Compare
Contributor
Author
|
@SirAionTech Thank you for your review and suggestions. I limited the fix to the local back-up now. |
SirAionTech
approved these changes
May 28, 2024
sergiocorato
approved these changes
Aug 21, 2024
Member
|
Included in merged #3089, so closing this one. |
Member
|
The merged PR still has the flaw that was corrected during the review of this PR. Can you have a look at #3217 to confirm this PR is the right fix for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.