[16.0][FIX] Database autobackup bugfix: exist_ok parameter does not exists in remote.makedirs() function #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As said on OCA#3139 there is no exist_ok parameter in remote.makedirs() function.
ignaciord
changed the title
StefanRijnhart
approved these changes
Sep 17, 2025
arielbarreiros96
approved these changes
Oct 18, 2025
arielbarreiros96
left a comment
arielbarreiros96
left a comment
There was a problem hiding this comment.
Ran into the same problem, LGTM
Member
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 35822c5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said on #3139 there is no exist_ok parameter in remote.makedirs() function.
So, with this PR the SFTP remote backup will work with no errors.
Thanks,
Ignacio