[10.0][MIG] base_kanban_stage #681

lasley · 2016-12-30T00:07:59Z

This is a forward port of #679

Rename manifest
Change openerp references to odoo
Bump version

* Add Kanban-compatible stage model web.kanban.stage * Add views, menu items, actions, and access controls needed to manage web.kanban.stage records * Add abstract model web.kanban.abstract that other models can inherit from to gain Kanban stage functionality * Add base Kanban view web_kanban_abstract_view_kanban, which can be customized as needed for use with models that inherit from web.kanban.abstract * Add model web.kanban.abstract.tester, which is needed for web.kanban.abstract unit tests

* Add Kanban-compatible stage model base.kanban.stage * Add views, menu items, actions, and access controls needed to manage base.kanban.stage records * Add abstract model base.kanban.abstract that other models can inherit from to gain Kanban stage functionality * Add base Kanban view base_kanban_abstract_view_kanban, which can be customized as needed for use with models that inherit from base.kanban.abstract * Add model base.kanban.abstract.tester, which is needed for base.kanban.abstract unit tests

* Rename manifest * Change openerp references to odoo * Bump version

* Update depends to `base` * Update priority selections to match Odoo guidelines * Update comment block to triple double quotes * Update `kanban_user_id` to `user_id` in code and view * Update README to incorporate use of mode in example view

lasley · 2017-01-07T17:50:28Z

Added missing commits from #679 - this is ready for review

dreispt · 2017-01-12T08:51:33Z

Hmm, your tests are failing...

lasley · 2017-01-15T03:38:30Z

And now they aren't failing! Good for review.

lasley · 2017-01-15T23:30:01Z

cc @LasLabs

jcdrubay · 2017-01-21T05:25:35Z

I wanted to test but it seems not easy to test because this module is abstract and therefore meaningless unless being used.

I tried to test combining the server-tool branch from LasLabs from this Pull Request + the LasLabs/vertical-medical:release/10.0 which contains an example for medical_prescription but I am getting an error...probably due to my environment :/

Is there any easier way to test?

Anyway, I believe we should move this PR forward quickly to help @lasley merging the LasLabs:vertical-medical to OCA.

The code looks good and includes with some tests 👍

lasley · 2017-01-27T02:11:31Z

@jcdrubay - Yeah I wish there was a better way to test this functionally, but yeah your way is pretty much the best.

Our incubator v10 has it in the oca_dependencies, and the medical_prescription_stage is already merged using it, so it can be tested directly on v10 branch of our Runbot if you'd like - https://runbot.laslabs.io/runbot/repo/git-github-com-laslabs-vertical-medical-git-41

I identified in LasLabs/vertical-medical#119 (comment) that there seems to be a bug that if a record is not in the stage, the stage will not actually appear on the view after a refresh.

This can be replicated by going to Medical => Dispensing => Add New Column => A Name => Add => Refresh the Page => New magic trick - Disappearing Stages

cc @obulkin

lasley · 2017-01-27T02:49:24Z

#681 (comment) is fixed in f7a3904 by using group_expand & updating to new API

* Add group_expand attr to abstract kanban model, allowing for empty columns * Fix `_read_group_stage_ids` for new API

obulkin · 2017-01-27T22:31:09Z

base_kanban_stage/tests/test_base_kanban_abstract.py

+            model_cls (openerp.models.BaseModel): Class of model to initialize
+        Returns:
+            model_cls: Instance
+        """


There are some issues with this docblock:

As currently written, the method does actually create a table for the model. That happens as part of _auto_init()

The var name in the Returns section is wrong

This came from template. Added note to PR https://github.com/OCA/maintainer-tools/pull/242/files#r98305473

jcdrubay

I tested in runbot of Laslabs for prescription and it works well.
I had reviewed the code already.
👍

lasley · 2017-01-31T02:07:44Z

base_kanban_stage/models/base_kanban_abstract.py

+
+    _name = 'base.kanban.abstract'
+    _order = 'kanban_priority desc, kanban_sequence'
+    _group_by_full = {


This can be removed

dreispt · 2017-02-05T15:55:40Z

Looks like it's good to merge... doing it.

Syncing from upstream OCA/server-tools (8.0)

lasley added the work in progress label Dec 30, 2016

lasley added this to the 10.0 milestone Dec 30, 2016

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch from 1f42aef to 422120f Compare December 30, 2016 00:10

Ted Salmon and others added 2 commits December 29, 2016 16:15

[MIG] base_kanban_stage: Upgrade to v10

2b2666a

* Rename manifest * Change openerp references to odoo * Bump version

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch from 422120f to 2b2666a Compare December 30, 2016 00:16

lasley mentioned this pull request Dec 30, 2016

[10.0][IMP] medical_prescription_stage: Switch to new kanban module LasLabs/vertical-medical#71

Closed

IMP] base_kanban_stage: Updates per PR

ae39fb3

* Update depends to `base` * Update priority selections to match Odoo guidelines * Update comment block to triple double quotes * Update `kanban_user_id` to `user_id` in code and view * Update README to incorporate use of mode in example view

lasley added needs review and removed work in progress labels Jan 7, 2017

dreispt added the needs fixing label Jan 12, 2017

pedrobaeza mentioned this pull request Jan 14, 2017

Migration to version 10.0 OCA/vertical-medical#117

Closed

37 tasks

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch 15 times, most recently from cfd588d to e9d43ce Compare January 15, 2017 03:35

lasley removed the needs fixing label Jan 15, 2017

Implement newer abstract test strategy

e0d6bb0

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch from e9d43ce to e0d6bb0 Compare January 15, 2017 03:41

dreispt approved these changes Jan 15, 2017

View reviewed changes

jcdrubay mentioned this pull request Jan 21, 2017

[10.0][IMP] medical_prescription_stage: Switch to new kanban module LasLabs/vertical-medical#118

Merged

lasley added work in progress and removed needs review labels Jan 27, 2017

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch from ed9c416 to 6f106d1 Compare January 27, 2017 02:47

lasley mentioned this pull request Jan 27, 2017

[9.0][FIX] base_kanban_stage: Add group_expand attr #716

Closed

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch from 6f106d1 to e9706ea Compare January 27, 2017 03:07

[FIX] base_kanban_stage: Add group_expand & fix method

f7a3904

* Add group_expand attr to abstract kanban model, allowing for empty columns * Fix `_read_group_stage_ids` for new API

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch from e9706ea to f7a3904 Compare January 27, 2017 03:08

lasley mentioned this pull request Jan 27, 2017

[10.0][IMP] medical_prescription_state: Add default states LasLabs/vertical-medical#119

Merged

1 task

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch from 6bfe00a to 393de7c Compare January 27, 2017 19:25

[FIX] base_kanban_stage: Fix test for new API

aebfc55

lasley force-pushed the feature/10.0/LABS-134-create-medical_base_stage-object branch from 393de7c to aebfc55 Compare January 27, 2017 19:56

obulkin reviewed Jan 27, 2017

View reviewed changes

jcdrubay approved these changes Jan 28, 2017

View reviewed changes

lasley commented Jan 31, 2017

View reviewed changes

dreispt merged commit 1329206 into OCA:10.0 Feb 5, 2017

lasley deleted the feature/10.0/LABS-134-create-medical_base_stage-object branch February 6, 2017 16:06

lasley mentioned this pull request Feb 7, 2017

Fix dependencies LasLabs/vertical-medical#130

Merged

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#681 from OCA/8.0

de1af9c

Syncing from upstream OCA/server-tools (8.0)

Uh oh!

[10.0][MIG] base_kanban_stage #681

[10.0][MIG] base_kanban_stage #681

Uh oh!

Conversation

lasley commented Dec 30, 2016

Uh oh!

lasley commented Jan 7, 2017

Uh oh!

dreispt commented Jan 12, 2017

Uh oh!

lasley commented Jan 15, 2017

Uh oh!

lasley commented Jan 15, 2017

Uh oh!

jcdrubay commented Jan 21, 2017

Uh oh!

lasley commented Jan 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lasley commented Jan 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

obulkin Jan 27, 2017

Choose a reason for hiding this comment

Uh oh!

lasley Jan 27, 2017

Choose a reason for hiding this comment

Uh oh!

jcdrubay left a comment

Choose a reason for hiding this comment

Uh oh!

lasley Jan 31, 2017

Choose a reason for hiding this comment

Uh oh!

dreispt commented Feb 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lasley commented Jan 27, 2017 •

edited

Loading

lasley commented Jan 27, 2017 •

edited

Loading