Skip to content

[9.0][FIX] base_kanban_stage: Add group_expand attr #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lasley wants to merge 2 commits into from
Closed

[9.0][FIX] base_kanban_stage: Add group_expand attr #716

lasley wants to merge 2 commits into from

Conversation

@lasley
Copy link
Contributor

@lasley lasley commented Jan 27, 2017 •
edited
Loading

Simple fix for issue described in #681 (comment):

  • Add group_expand attr to abstract kanban model, allowing for empty columns
  • Fix _read_group_stage_ids for new API

cc @dreispt @obulkin

@lasley lasley added this to the 9.0 milestone Jan 27, 2017
@lasley
[FIX] base_kanban_stage: Add group_expand & fix method
902bcc1 
* Add group_expand attr to abstract kanban model, allowing for empty columns
* Fix `_read_group_stage_ids` for new API
@lasley lasley force-pushed the bugfix/9.0/base_kanban_stage-read_group_stage_ids branch from e347dc1 to 902bcc1 Compare January 27, 2017 03:10
@lasley
Copy link
Contributor Author

lasley commented Jan 27, 2017 •
edited
Loading

Oops it seems I didn't update the tests - I noticed this in the v10 PR & have cherry picked here. I forget how important CI is until it goes away! I fixed the v9 build with #719 in light of this almost-whoopsie as well.

@lasley
Copy link
Contributor Author

lasley commented Jan 27, 2017

In a conversation with @obulkin, we determined that I implemented this wrong for 9. I'm going to wait on our CIs then come back to this. Sorry to bring you in with it broken @dreispt!

The way it should be done in v9

@lasley
Copy link
Contributor Author

lasley commented Jan 31, 2017

Ok yup so this is irrelevant in 9, my bad. Implementation is confirmed good & I can actually remove a few more lines in the pending v10 PR. I love removing code 😄

@lasley lasley closed this Jan 31, 2017
@lasley lasley deleted the bugfix/9.0/base_kanban_stage-read_group_stage_ids branch January 31, 2017 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreispt dreispt dreispt approved these changes

Assignees

No one assigned

Labels

bug work in progress

Projects

None yet

Milestone

9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lasley @dreispt