Closed
Conversation
acsonefho
force-pushed
the
13.0-storage_backend_ftp
branch
2 times, most recently
from
f6b5104 to
2400d17
Compare
acsonefho
changed the title
acsonefho
force-pushed
the
13.0-storage_backend_ftp
branch
3 times, most recently
from
1107ef6 to
a2014d4
Compare
acsonefho
force-pushed
the
13.0-storage_backend_ftp
branch
from
a2014d4 to
48e1336
Compare
acsonefho
force-pushed
the
13.0-storage_backend_ftp
branch
from
48e1336 to
a169408
Compare
Contributor
LoisRForgeFlow
left a comment
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
I did an initial test, see a comment inline.
Contributor
There was a problem hiding this comment.
This does not return a list. But a string with a command-like message. I think you should use client.nlst(full_path)
* list should return a python list of files. * get should get and directly return the bynary from the FTP. Before, a string was being retrived and then encoded. This is problematic if the original binary was not utf-8.
Contributor
|
Hi @acsonefho, I have done a full testing and found a couple of issues. I have created a PR to your branch addressing them, could you have a look? acsone#1 |
[FIX] storage_backend_ftp: fix list and get
simahawk
approved these changes
Sep 9, 2021
| # Due to a bug into between ftplib and ssl, this part (about ssl) might not work! | ||
| # https://bugs.python.org/issue31727 | ||
| security = None | ||
| if backend.ftp_security == "tls": |
| ) | ||
|
|
||
| # Do not patch the entire ftplib otherwise the error_perm Exception | ||
| # become also a mock and then a traceback is genrated on the "except ftplib.error_perm" |
Contributor
There was a problem hiding this comment.
Suggested change
| # become also a mock and then a traceback is genrated on the "except ftplib.error_perm" | |
| # become also a mock and then a traceback is generated on the "except ftplib.error_perm" |
| sftp_port = fields.Integer(string="SFTP Port", default=22) | ||
| sftp_auth_method = fields.Selection( | ||
| string="Authentification Method", | ||
| string="SFTP Authentification Method", |
Contributor
There was a problem hiding this comment.
Suggested change
| string="SFTP Authentification Method", | |
| string="SFTP Authentication Method", |
Contributor
|
build is red |
Contributor
|
@acsonefho could you attend the final comments from @simahawk ? |
Contributor
|
I have superseded this PR due to inactivity here #134, I think we can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New module
storage_backend_ftpNote: I didn't test every security protocols