[FIX] storage_backend_ftp: fix list and get#1
Merged
acsonefho merged 1 commit intoacsone:13.0-storage_backend_ftpfrom Aug 30, 2021
Merged
Conversation
* list should return a python list of files. * get should get and directly return the bynary from the FTP. Before, a string was being retrived and then encoded. This is problematic if the original binary was not utf-8.
acsonefho
requested changes
Aug 5, 2021
acsonefho
left a comment
acsonefho
left a comment
There was a problem hiding this comment.
Great! Thank you for your improvement!
Can you also update unit test (if necessary)?
Thanks!
Author
|
Could you do it? You have created then and probably you will adapt faster, also that would allow you to test my changes :) |
No problem but probably next week =/ |
Author
|
Thanks! |
Author
|
@acsonefho could you merge this? |
acsonefho
approved these changes
Aug 30, 2021
lmignon
added a commit
that referenced
this pull request
Mar 24, 2023
sbejaoui
pushed a commit
that referenced
this pull request
Aug 14, 2023
sbejaoui
pushed a commit
that referenced
this pull request
Aug 14, 2023
lmignon
added a commit
that referenced
this pull request
Oct 9, 2023
benwillig
pushed a commit
that referenced
this pull request
Jan 10, 2024
benwillig
pushed a commit
that referenced
this pull request
Jan 10, 2024
benwillig
pushed a commit
that referenced
this pull request
Jan 11, 2024
lmignon
added a commit
that referenced
this pull request
Nov 10, 2024
pierre-halleux
pushed a commit
that referenced
this pull request
Feb 14, 2025
lmignon
added a commit
that referenced
this pull request
Mar 24, 2025
lmignon
added a commit
that referenced
this pull request
May 28, 2025
lmignon
added a commit
that referenced
this pull request
May 28, 2025
lmignon
added a commit
that referenced
this pull request
May 28, 2025
lmignon
added a commit
that referenced
this pull request
May 28, 2025
lmignon
added a commit
that referenced
this pull request
May 28, 2025
lmignon
added a commit
that referenced
this pull request
Sep 15, 2025
FrancoMaxime
pushed a commit
that referenced
this pull request
Dec 8, 2025
fixup! [19.0][MIG] fs_storage Migration 19.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, a string was being retrived and then encoded. This is
problematic if the original binary was not utf-8.