Closed
Conversation
…ule, storage_image and storage_thumbnail add a generic mixing for thumbnail owner
…t with the specifiation of the type of file binary or base64
…or add and removing file on backend private
…ar the cache manually anymore
…l key, extract method for building the domain, generate the url of the image correclty and add a test
… each thumbnail to retrieve
… to avoid trouble with the ORM
The URL for all storage files is normally computed via backend. This ensures that if you have different conf by env you won't mess up w/ images coming from other envs (eg: prod). This change makes sure that the URL which is used for the thumbs is always computed by the backend.
Fixes the following warning: Wrong Import in module storage_thumbnail, the class <class 'odoo.addons.storage_thumbnail.tests.models.ModelTest'> have been already imported.
The backend flag 'backend_view_use_internal_url' can be used to control whether to use internal url or public url for showing images in the backend w/ thumbs urls.
ACL is not relevant at all in these cases.
sbejaoui
force-pushed
the
16.0-storage_thumbnail-sbj
branch
from
551a53f to
b4a543b
Compare
sbejaoui
force-pushed
the
16.0-storage_thumbnail-sbj
branch
from
b4a543b to
a8409f5
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends: