[18.0][MIG] fs_image by rousseldenis · Pull Request #446 · OCA/storage

rousseldenis · 2025-02-19T17:03:20Z

Depends on:

[18.0][MIG] fs_file #445

Store your image into an external filesystem

Currently translated at 100.0% (14 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/es/

Currently translated at 92.8% (13 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/it/

Currently translated at 100.0% (14 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/it/

Fix a bug in the initialization of the image field value object when the field is read. Before this fix, every time the value object was initialized with an attachment, an assignment of the alt text was done into the constructor. This assignment triggered the mark of the field as modified and an SQL update query was generated at the end of the request. The alt text in the constructor of the FSImageValue class must only be used when the class is initialized without an attachment. We now check if an attachment and an alt text are provided at the same time and throw an exception if this is the case.

rawCacheKey is properly managed by STD

Currently translated at 78.5% (11 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/fr/

Before this change the creation of empty file was not supported. The issue was mainly due to the fact that at create of a FSFileValue instance with a name but without content, the name was no preserved. As result, the insert of the attachement into the DB failed since the name is a required field. If a FSFileValue instance is now created without content but with a name, the name is now preserved on an empty buffer.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/

On image hover, a download button is now available to easily download the image

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/

Currently translated at 100.0% (15 of 15 strings) Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/it/

lmignon · 2025-02-24T08:41:26Z

/ocabot migration fs_image

lmignon

LGTM (Code review + diff with 16.0 and functional via #449)

xaviedoanhduy

have some small changes but LGTM

xaviedoanhduy · 2025-04-22T08:00:00Z

fs_image/static/src/views/dialogs/alttext_dialog.esm.js

@@ -0,0 +1,40 @@
+/** @odoo-module */


Suggested change

/** @odoo-module */

xaviedoanhduy · 2025-04-22T08:01:06Z

fs_image/static/src/views/dialogs/alttext_dialog.esm.js

+
+import {Dialog} from "@web/core/dialog/dialog";
+
+const {Component, useRef} = owl;


Suggested change

const {Component, useRef} = owl;

import {Component, useRef} from "@odoo/owl";

xaviedoanhduy · 2025-04-22T08:03:45Z

fs_image/static/src/views/dialogs/alttext_dialog.xml

+        <Dialog size="'md'" title="props.title">
+            <div class="form-group row">
+                <t t-if="props.readonly">
+                    <span t-esc="props.value or ''" />


Suggested change

<span t-esc="props.value or ''" />

<span t-out="props.value or ''" />

xaviedoanhduy · 2025-04-22T08:04:17Z

fs_image/static/src/views/fields/fsimage_field.esm.js

@@ -0,0 +1,113 @@
+/** @odoo-module */


Suggested change

/** @odoo-module */

xaviedoanhduy · 2025-04-22T08:05:15Z

fs_image/static/src/views/fields/fsimage_field.esm.js

+export class FSImageField extends ImageField {
+    setup() {
+        // Call super.setup() to initialize the state
+        super.setup(...arguments);


Suggested change

super.setup(...arguments);

super.setup();

kobros-tech · 2025-06-23T14:02:08Z

@rousseldenis

can we solve conflict?

If you are busy I would open a new PR based on this one?

lmignon · 2025-08-19T08:57:17Z

@rousseldenis Can you fix your PR so we can proceed to the merge?

xaviedoanhduy · 2025-08-19T09:22:09Z

fs_image/static/src/views/fields/fsimage_field.xml

+                t-att-width="props.width"
+                t-att-style="sizeStyle"
+                t-att-alt="props.alt"
+                t-on-error.stop="onLoadFailed"


Suggested change

t-on-error.stop="onLoadFailed"

t-on-error.stop="onLoadFailed"

it should be t-on-error-stop, no?

What do you need here, what is the suggested change please?

alright, t-on-error.stop is the correct modifier.

lmignon · 2025-09-24T16:48:23Z

merged in #515

lmignon and others added 30 commits February 19, 2025 16:49

[ADD] fs_image: Field to store images

78535e0

Store your image into an external filesystem

[UPD] Update fs_image.pot

95ea19b

[BOT] post-merge updates

3781460

Added translation using Weblate (Spanish)

72d31ec

Translated using Weblate (Spanish)

5018128

Currently translated at 100.0% (14 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/es/

Added translation using Weblate (Italian)

9e8e42c

Translated using Weblate (Italian)

635b40e

Currently translated at 92.8% (13 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/it/

Translated using Weblate (Italian)

8b1be57

Currently translated at 100.0% (14 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/it/

[BOT] post-merge updates

87bc491

[FIX] fs_image: remove rawCacheKey invalidation

4e3d8ca

rawCacheKey is properly managed by STD

[BOT] post-merge updates

7fe0200

Added translation using Weblate (French)

d7eb7cf

Translated using Weblate (French)

671ac7a

Currently translated at 78.5% (11 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/fr/

[BOT] post-merge updates

0e14f3f

[IMP] fs_image: pre-commit auto fixes

8f6c8a0

[MIG] fs_image: Migration to 17.0

14811a3

[UPD] Update fs_image.pot

eed8050

[BOT] post-merge updates

7233eee

[FIX] pre-commit

0a3ad3e

[BOT] post-merge updates

af5ba32

[UPD] Update fs_image.pot

6af35ce

Update translation files

a093bcf

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/

[IMP] fs_image: Add download button

d1b9457

On image hover, a download button is now available to easily download the image

[UPD] Update fs_image.pot

7982754

[BOT] post-merge updates

ba686d0

Update translation files

054962b

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/

Translated using Weblate (Italian)

4fae5d5

Currently translated at 100.0% (15 of 15 strings) Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/it/

[IMP] fs_image: pre-commit autofixes

0e6e63f

rousseldenis force-pushed the 18.0-mig-fs-image-dro branch from 6181721 to 3d05917 Compare February 19, 2025 17:08

[MIG] fs_image: Migration to 18.0

47b05bb

rousseldenis force-pushed the 18.0-mig-fs-image-dro branch from 3d05917 to 47b05bb Compare February 19, 2025 17:15

rousseldenis mentioned this pull request Feb 20, 2025

[18.0][MIG] fs_base_multi_image #447

Closed

[FIX] fs_image: Use rawCacheKey as unique

2f7a338

rousseldenis mentioned this pull request Feb 20, 2025

[18.0][MIG] fs_product_multi_image #449

Closed

OCA-git-bot added this to the 18.0 milestone Feb 24, 2025

OCA-git-bot mentioned this pull request Feb 24, 2025

Migration to version 18.0 #398

Open

26 tasks

lmignon approved these changes Feb 24, 2025

View reviewed changes

xaviedoanhduy approved these changes Apr 22, 2025

View reviewed changes

This was referenced Apr 23, 2025

[18.0][MIG] fs_image_thumbnail: Migration to 18.0 #470

Open

[18.0][MIG] fs_import_image_advanced*: Migration to 18.0 #473

Open

kobros-tech approved these changes Jun 23, 2025

View reviewed changes

kobros-tech mentioned this pull request Aug 17, 2025

[18.0][MIG] fs_file_demo: Migration to 18.0 #504

Open

xaviedoanhduy reviewed Aug 19, 2025

View reviewed changes

kobros-tech mentioned this pull request Aug 19, 2025

[18.0][MIG] fs_product_brand_multi_image: Migration to 18.0 #505

Open

kobros-tech mentioned this pull request Sep 21, 2025

[MIG] fs_image: Migration to 18.0 #515

Merged

lmignon closed this Sep 24, 2025

lmignon deleted the 18.0-mig-fs-image-dro branch September 24, 2025 16:48


		import {Dialog} from "@web/core/dialog/dialog";

		const {Component, useRef} = owl;

	const {Component, useRef} = owl;
	import {Component, useRef} from "@odoo/owl";

	<span t-esc="props.value or ''" />
	<span t-out="props.value or ''" />

	t-on-error.stop="onLoadFailed"
	t-on-error.stop="onLoadFailed"

Uh oh!

Conversation

rousseldenis commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmignon commented Feb 24, 2025

Uh oh!

lmignon left a comment

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy left a comment

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

kobros-tech commented Jun 23, 2025

Uh oh!

lmignon commented Aug 19, 2025

Uh oh!

xaviedoanhduy Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kobros-tech Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

lmignon commented Sep 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

rousseldenis commented Feb 19, 2025 •

edited

Loading

xaviedoanhduy Aug 19, 2025 •

edited

Loading