Closed
Conversation
Ensures the variant_image_ids are sorted by sequence and name. Before this change, the order was random and could change between runs.
Currently translated at 100.0% (33 of 33 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/es/
Currently translated at 100.0% (33 of 33 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
Currently translated at 100.0% (33 of 33 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
Currently translated at 100.0% (33 of 33 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
…th same label for image/image_1920 and image_medium/image_128 for product.template and product.product
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/
Currently translated at 100.0% (34 of 34 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/it/
… compare integer and NewId
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/
Currently translated at 100.0% (34 of 34 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/es/
… or there will be an owl error
Currently translated at 76.4% (26 of 34 strings) Translation: storage-16.0/storage-16.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_image/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_product_multi_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_product_multi_image/
Contributor
Author
|
@lmignon I've solved most of technical issues I've found. The last one is that loaded images seem incoherent between display in product image tab and in the relation popup display:
Tested with runboat |
Contributor
|
/ocabot migration fs_product_multi_image |
lmignon
requested changes
Feb 24, 2025
Comment on lines
51
to
56
| <!-- <img | ||
| t-att-src="kanban_image('fs.product.image', 'image_medium', record.id.raw_value)" | ||
| t-if="record.id" | ||
| alt="Image" | ||
| class="o_image_64_contain" | ||
| /> --> |
Contributor
There was a problem hiding this comment.
This code should be removed
| <div class="o_kanban_image me-1"> | ||
| <field | ||
| name="image_medium" | ||
| widget="image" |
Contributor
There was a problem hiding this comment.
The widget to use is 'fs_image'
Suggested change
| widget="image" | |
| widget="fs_image" |
With this change everything works properly on runboat.
This was referenced Feb 24, 2025
Merged
Closed
rousseldenis
force-pushed
the
18.0-mig-fs-product-multi-image-dro
branch
from
542c0ab to
0b539e1
Compare
rousseldenis
force-pushed
the
18.0-mig-fs-product-multi-image-dro
branch
from
0b539e1 to
cd10cd9
Compare
Contributor
once you save the image you find the image itself is displayed instead of this placeholder image, I don't mind this behaviour. |
kobros-tech
suggested changes
Jun 23, 2025
Contributor
kobros-tech
left a comment
kobros-tech
left a comment
There was a problem hiding this comment.
although the conflict and test cases, I approve the migration.
Contributor
|
do you need my help with test cases and merge conflicts? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: