Update ope class validation constraint & constrainttemplate #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having to specify the exact numerical cpu and mem requests and limits, you can now just specify string size mapping to those numbers "X Small", "Small" etc. Signed-off-by: Isaiah Stapleton <istaplet@redhat.com>
Rather than being restricted to selecting only 1 image, can now specify multiple allowed images in a class validation constraint. Signed-off-by: Isaiah Stapleton <istaplet@redhat.com>
IsaiahStapleton
requested review from
DanNiESh,
dystewart,
larsks,
memalhot and
tssala23
This commit adds the following features to the ope validation constrainttemplate: - Ability to specify resource size PER image: We can now specify which resource sizes are allowed for a specific image. Whereas before you could only specify one resource size for all images. - Ability to specify # of GPUs an image is allowed: We are now able to specify how many GPUs a specific image is allowed to claim. Signed-off-by: Isaiah Stapleton <istaplet@redhat.com>
tssala23
approved these changes
Jul 10, 2025
memalhot
approved these changes
Jul 10, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds three commits that do the following:
Simplify constraint parameters:
Rather than having to specify the exact numerical cpu and mem requests
and limits, you can now just specify string size mapping to those
numbers "X Small", "Small" etc.
ope constraint: support multiple allowed images
Rather than being restricted to selecting only 1 image, can now specify
multiple allowed images in a class validation constraint.
Ability to specify resource size PER image: We can now specify which
resource sizes are allowed for a specific image. Whereas before you
could only specify one resource size for all images.
Ability to specify # of GPUs an image is allowed: We are now able to
specify how many GPUs a specific image is allowed to claim.