Skip to content

Create phasor dynamics model data structures (take two)#116

Merged
pelesh merged 7 commits intodevelopfrom
slaven/phasor_dynamics_data_dev
May 31, 2025
Merged

Create phasor dynamics model data structures (take two)#116
pelesh merged 7 commits intodevelopfrom
slaven/phasor_dynamics_data_dev

Conversation

@pelesh
Copy link
Copy Markdown
Collaborator

@pelesh pelesh commented May 27, 2025

Description

Create data structures to store model data for each component model type, e.g. an electrical machine data structure. These data structures will contain a superset of parameters for each component model type.

@abirchfield @lukelowry @alexander-novo @reid-g @abdourahmanbarry

Proposed changes

The purpose of these data structures is to decouple data input from component models, so that:

  • Multiple inputs (GUI, file input, etc.) can be used to enter system model data in GridKit.
  • Multiple component model implementations can use the same data structures to instantiate the component.
  • Analysis can be performed on these data structures to compute sparsity pattern of system Jacobian without even instantiating the component or system models.

The changes proposed in the PR are the first step in this direction.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@pelesh pelesh self-assigned this May 27, 2025
@pelesh pelesh added enhancement New feature or request new model labels May 27, 2025
@pelesh pelesh changed the title Slaven/phasor dynamics data dev Create phasor dynamics model data structures (take two) May 27, 2025
Comment thread src/Model/PhasorDynamics/Branch/Branch.hpp Outdated
Comment thread src/Model/PhasorDynamics/Bus/BusInfinite.cpp
Comment thread src/Model/PhasorDynamics/Bus/Bus.cpp
Comment thread src/Model/PhasorDynamics/Load/Load.hpp Outdated
@pelesh pelesh force-pushed the slaven/phasor_dynamics_data_dev branch from 8a10d71 to 8fcb325 Compare May 30, 2025 21:23
@pelesh pelesh merged commit 7086fe7 into develop May 31, 2025
@pelesh pelesh deleted the slaven/phasor_dynamics_data_dev branch June 10, 2025 18:02
WiktoriaZielinskaORNL pushed a commit that referenced this pull request Jul 23, 2025
* Create phasor dynamics bus and branch data structures.

* Add load data structure.

* Use BusData with BusInfinite.

* Renamed PowerSystemData -> PowerFlowData


---------

Co-authored-by: pelesh <pelesh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants