Skip to content

Create phasor dynamics model data structures#115

Closed
pelesh wants to merge 5 commits intoslaven/refactor_powerflow_devfrom
slaven/phasor_dynamics_data_dev
Closed

Create phasor dynamics model data structures#115
pelesh wants to merge 5 commits intoslaven/refactor_powerflow_devfrom
slaven/phasor_dynamics_data_dev

Conversation

@pelesh
Copy link
Copy Markdown
Collaborator

@pelesh pelesh commented May 27, 2025

Description

@abirchfield @lukelowry @alexander-novo @reid-g @abdourahmanbarry

Proposed changes

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@pelesh pelesh self-assigned this May 27, 2025
@pelesh pelesh added the enhancement New feature or request label May 27, 2025
pelesh and others added 5 commits May 27, 2025 12:58
…ctories (#114)

* Mowe PowerSystemsData.hpp to src/Models/PowerFlow.

* Move CircuitGraph.hpp to Model/PowerElectronics

* Move Matpower parser to src/Model/PowerFlow

---------

Co-authored-by: pelesh <pelesh@users.noreply.github.com>
@pelesh pelesh force-pushed the slaven/phasor_dynamics_data_dev branch from 606efaa to 8a10d71 Compare May 27, 2025 17:16
@superwhiskers
Copy link
Copy Markdown
Collaborator

i don't think this is related to any change made in this pull request, but there's a segfault in the example AdjointSens in the destructor AnalysisManager::Sundials::Ida::~Ida caused by Ida::deleteAdjoint() calling IDAAdjFree(solver_) and then Ida::deleteSimulation() calling IDAFree(&solver_) which calls IDAAdjFree(...) as well. from what i can tell, the best way to solve this would be to remove the call to Ida::deleteAdjoint() in the destructor, but i could be wrong about this.

@pelesh
Copy link
Copy Markdown
Collaborator Author

pelesh commented May 27, 2025

i don't think this is related to any change made in this pull request, but there's a segfault in the example AdjointSens in the destructor AnalysisManager::Sundials::Ida::~Ida caused by Ida::deleteAdjoint() calling IDAAdjFree(solver_) and then Ida::deleteSimulation() calling IDAFree(&solver_) which calls IDAAdjFree(...) as well. from what i can tell, the best way to solve this would be to remove the call to Ida::deleteAdjoint() in the destructor, but i could be wrong about this.

This issue was supposed to be fixed in SUNDIAL PR 704. For now, we need to use SUNDIALS from develop branch.

@pelesh
Copy link
Copy Markdown
Collaborator Author

pelesh commented May 27, 2025

Closing this in favor of #116.

@pelesh pelesh closed this May 27, 2025
@superwhiskers superwhiskers mentioned this pull request May 28, 2025
@superwhiskers superwhiskers mentioned this pull request Jun 9, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants