Add classical generator model#127
Merged
Merged
Conversation
pelesh
added
enhancement
pelesh
force-pushed
the
slaven/gen_classical_dev
branch
from
9a0c7a1 to
25693a8
Compare
Collaborator
abdourahmanbarry
left a comment
abdourahmanbarry
left a comment
There was a problem hiding this comment.
I have not found any issues. I think this looks great!
abdourahmanbarry
approved these changes
Jun 5, 2025
abirchfield
approved these changes
Jun 5, 2025
This was referenced Jun 5, 2025
Closed
WiktoriaZielinskaORNL
pushed a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add classical generator (second order) model to phasor domain dynamics family.
Closes #73
@alexander-novo @reid-g @lukelowry
Proposed changes
Implemented model and unit test borrowing from PR #94. Fixed (hopefully) some errors in the code and documentation, most notably the sign for the stator susceptance. The model has not been tested in simulations yet, only with unit tests.
Creating a usage example is out of scope for this PR.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Documentation needs to be proofread by a domain expert before this should be merged.