Conversation
superwhiskers
approved these changes
Jun 27, 2025
Collaborator
superwhiskers
left a comment
superwhiskers
left a comment
There was a problem hiding this comment.
i've tested this on my machine with sundials 7.4.0. i'm unable to run the enzyme tests as it looks like i need to mess around with enzyme a little to get it to work right but all of the tests i am able to run pass without issue. this should be fine to merge.
Collaborator
Author
|
I'll need to wait to update GridKit/.github/workflows/spack_default_build.yaml Lines 144 to 145 in fd3dfc6 until the SUNDIALS spack package gets updated, hopefully in a couple days. |
WiktoriaZielinskaORNL
pushed a commit
that referenced
this pull request
Jul 23, 2025
* Update build requirements to SUNDIALS version 7.4.0 * Updated Spack fork with sundials@7.4.0 and set CI to use that version. (#164) --------- Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to latest version of SUNDIALS which includes a bug fix for IDA that was previously causing a seg fault in #105
Checklist
-Wall -Wpedantic -Wconversion -Wextra.