CI upgrades to support sundials@7.4.0

[nkoukpaizan]

Description

CI upgrades to support sundials@7.4.0

Proposed changes

Updated Spack fork with sundials@7.4.0 and setting CI to use that version.

Checklist

• All tests pass.
• Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
• [N/A] The new code follows GridKit™ style guidelines.
• [N/A] There are unit tests for the new code.
• [N/A] The new code is documented.
• The feature branch is rebased with respect to the target branch.

[Steven-Roberts]

Someone on the SUNDIALS team should be opening a PR to update the spack package for v7.4.0 today.

Does this need updating too?

GridKit/.devcontainer/Dockerfile

Line 24 in f529ebc

RUN git clone --single-branch --branch develop https://github.com/LLNL/sundials.git /tmp/sundials && \

[nkoukpaizan]

Someone on the SUNDIALS team should be opening a PR to update the spack package for v7.4.0 today.

Does this need updating too?

GridKit/.devcontainer/Dockerfile

Line 24 in f529ebc

RUN git clone --single-branch --branch develop https://github.com/LLNL/sundials.git /tmp/sundials && \

Yes, the container should be updated too. There is a specific commit being set. cc @superwhiskers @alexander-novo

Note that for CI, we are currently pointing Spack to my fork, which is behind upstream Spack. So, yes we want the new SUNDIALS version to be in upstream spack and I will let the SUNDIALS team do that, but we wouldn't get that update in CI.

[pelesh]

SUNDIALS Spack has been updated and correct version of the library has been set in our CI.