Skip to content

Exciter Implementation and Example#192

Merged
pelesh merged 15 commits into
developfrom
lukel/ieeet1_node_dev
Jul 24, 2025
Merged

Exciter Implementation and Example#192
pelesh merged 15 commits into
developfrom
lukel/ieeet1_node_dev

Conversation

@lukelowry
Copy link
Copy Markdown
Collaborator

@lukelowry lukelowry commented Jul 20, 2025

Description

This PR includes a working Exciter model (IEEET1) with the relevant GENROU modifications and an example for verification.

Motivation: Once this model is implemented, we can start constructing IEEE cases and synthetic cases which are stable without an infinite bus.

Proposed changes

  • Exciter header and source Ieeet1.hpp Ieeet1.cpp
  • Exciter data, copying GenrouData.hpp
  • Genrou support for Exciter (removed one state and add read/write for efd signal)
  • Add Exciter list in SystemModelData
  • Two Bus example TwoBusIeeet1.cpp
    -- Update ThreeBus example that relies on old GENROU state vector size.
  • Various README updates to align with implementation

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

The data-based signal connections are not supported in this PR, since exact approach is TBD.

I addressed my environment git issue, so no more commit storms. Forgive me!

@lukelowry lukelowry self-assigned this Jul 20, 2025
Copy link
Copy Markdown
Collaborator

@superwhiskers superwhiskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some really minor suggestions. i apologize for the abundance of typo corrections.

Comment thread src/Model/PhasorDynamics/SystemModelData.hpp
Comment thread src/Model/PhasorDynamics/SynchronousMachine/GENROUwS/GenrouImpl.hpp
Comment thread src/Model/PhasorDynamics/Exciter/IEEET1/Ieeet1Data.hpp Outdated
Comment thread src/Model/PhasorDynamics/Exciter/IEEET1/Ieeet1Data.hpp Outdated
Comment thread src/Model/PhasorDynamics/Exciter/IEEET1/Ieeet1Data.hpp
Comment thread src/Model/PhasorDynamics/Exciter/IEEET1/Ieeet1.cpp Outdated
Comment thread src/Model/PhasorDynamics/Exciter/IEEET1/Ieeet1.cpp Outdated
Comment thread src/Model/PhasorDynamics/Exciter/IEEET1/Ieeet1.cpp Outdated
Comment thread src/Model/PhasorDynamics/Exciter/IEEET1/Ieeet1.cpp Outdated
Comment thread src/Model/PhasorDynamics/Exciter/IEEET1/Ieeet1.cpp Outdated
lukelowry and others added 5 commits July 21, 2025 10:17
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
@lukelowry
Copy link
Copy Markdown
Collaborator Author

Awaiting review of changes. Thank you @superwhiskers and @pelesh!

@lukelowry lukelowry requested a review from superwhiskers July 21, 2025 16:42
Copy link
Copy Markdown
Collaborator

@superwhiskers superwhiskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some memory safety bugs and memory leaks. everything else looks fine.

Comment thread examples/PhasorDynamics/Tiny/TwoBus/Ieeet1/TwoBusIeeet1.cpp Outdated
Comment thread examples/PhasorDynamics/Tiny/TwoBus/Ieeet1/TwoBusIeeet1.cpp Outdated
lukelowry and others added 2 commits July 22, 2025 01:08
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
@lukelowry
Copy link
Copy Markdown
Collaborator Author

All review comments addressed. I am excited to get larger cases implemented after this PR. @superwhiskers and @pelesh

Copy link
Copy Markdown
Collaborator

@superwhiskers superwhiskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues appear to remain

@superwhiskers
Copy link
Copy Markdown
Collaborator

nevermind. #193 should be merged before this is ready to be merged as it will provide the signal bus functionality.

@pelesh pelesh merged commit a0ac4a5 into develop Jul 24, 2025
@lukelowry lukelowry deleted the lukel/ieeet1_node_dev branch July 24, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants