Exciter Implementation and Example#192
Merged
Merged
Conversation
superwhiskers
requested changes
Jul 21, 2025
Collaborator
superwhiskers
left a comment
There was a problem hiding this comment.
just some really minor suggestions. i apologize for the abundance of typo corrections.
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Collaborator
Author
|
Awaiting review of changes. Thank you @superwhiskers and @pelesh! |
superwhiskers
requested changes
Jul 21, 2025
Collaborator
superwhiskers
left a comment
There was a problem hiding this comment.
some memory safety bugs and memory leaks. everything else looks fine.
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
Collaborator
Author
|
All review comments addressed. I am excited to get larger cases implemented after this PR. @superwhiskers and @pelesh |
superwhiskers
approved these changes
Jul 22, 2025
Collaborator
superwhiskers
left a comment
There was a problem hiding this comment.
no issues appear to remain
Collaborator
|
nevermind. #193 should be merged before this is ready to be merged as it will provide the signal bus functionality. |
pelesh
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a working Exciter model (IEEET1) with the relevant GENROU modifications and an example for verification.
Motivation: Once this model is implemented, we can start constructing IEEE cases and synthetic cases which are stable without an infinite bus.
Proposed changes
-- Update ThreeBus example that relies on old GENROU state vector size.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
The data-based signal connections are not supported in this PR, since exact approach is TBD.
I addressed my environment git issue, so no more commit storms. Forgive me!