Skip to content

initial attempt at a unified interface to signal buses#193

Merged
pelesh merged 8 commits into
developfrom
signal-setting
Jul 29, 2025
Merged

initial attempt at a unified interface to signal buses#193
pelesh merged 8 commits into
developfrom
signal-setting

Conversation

@superwhiskers
Copy link
Copy Markdown
Collaborator

an attempt at providing an interface to signal buses on components

closes #190

checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Copy link
Copy Markdown
Collaborator

@shakedregev shakedregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems easier from the user perspective compared to #199. Let's make sure this runs smoothly.

@superwhiskers superwhiskers reopened this Jul 24, 2025
@superwhiskers superwhiskers marked this pull request as ready for review July 28, 2025 20:30
@superwhiskers
Copy link
Copy Markdown
Collaborator Author

this is probably ready for review now. i don't think changing constructors is appropriate just yet. doing that will be more appropriate when they way they're handled in the json format / data model is worked out. all this pull request does is unify the way components handle them internally, in preparation for a more involved change.

@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Jul 28, 2025

this is probably ready for review now. i don't think changing constructors is appropriate just yet. doing that will be more appropriate when they way they're handled in the json format / data model is worked out. all this pull request does is unify the way components handle them internally, in preparation for a more involved change.

You just need to modify genrou and tgov1 data structures. We can assemble them manually, without a parser in an example. With Genrou and Tgov1 constructors taking in the data structures and initializing signal connections, this PR will be ready to merge.

Other than that, this is very nice work and the code is clean and readable.

Comment thread src/Model/PhasorDynamics/Governor/Tgov1/Tgov1.cpp
Copy link
Copy Markdown
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pelesh pelesh merged commit cc9b27b into develop Jul 29, 2025
4 checks passed
@superwhiskers superwhiskers deleted the signal-setting branch July 29, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a generalized signal setter function

4 participants