Skip to content

different implementation of signal assignment#199

Closed
superwhiskers wants to merge 2 commits into
developfrom
new-signal-setting
Closed

different implementation of signal assignment#199
superwhiskers wants to merge 2 commits into
developfrom
new-signal-setting

Conversation

@superwhiskers
Copy link
Copy Markdown
Collaborator

another attempt at implementing signal assignment on components

closes #190

checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

@superwhiskers superwhiskers requested a review from pelesh July 24, 2025 14:31
Copy link
Copy Markdown
Collaborator

@shakedregev shakedregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code requires the user to memorize relations between enums and integers. There are multiple problems with type safety. I recommend improving #193 instead.

@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Jul 24, 2025

Branch is not the best example to work this out because a branch does not have signal connections. I would use generator and governor as my two test cases.

@superwhiskers
Copy link
Copy Markdown
Collaborator Author

closing in favor of #193

@superwhiskers superwhiskers deleted the new-signal-setting branch July 29, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a generalized signal setter function

3 participants