different implementation of signal assignment#199
Closed
superwhiskers wants to merge 2 commits into
Closed
Conversation
shakedregev
reviewed
Jul 24, 2025
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
This code requires the user to memorize relations between enums and integers. There are multiple problems with type safety. I recommend improving #193 instead.
6 tasks
Collaborator
|
Branch is not the best example to work this out because a branch does not have signal connections. I would use generator and governor as my two test cases. |
Collaborator
Author
|
closing in favor of #193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
another attempt at implementing signal assignment on components
closes #190
checklist
-Wall -Wpedantic -Wconversion -Wextra.