Skip to content

Stabilizer Docs + IEEEST Implementation#365

Merged
nkoukpaizan merged 8 commits intodevelopfrom
lukel/ieeest-dev
Apr 17, 2026
Merged

Stabilizer Docs + IEEEST Implementation#365
nkoukpaizan merged 8 commits intodevelopfrom
lukel/ieeest-dev

Conversation

@lukelowry
Copy link
Copy Markdown
Collaborator

@lukelowry lukelowry commented Apr 8, 2026

Description

Cleaned the Stabilizer folder in the PhasorDynamics to align it with the other models' folder structures. The documentation and implementation, or IEEEST, was also added.

This is one of the last essential models we need to faithfully model some of the larger cases. It's best to implement this before creating rigorous tests for big cases.

Proposed changes

  • Make a general Stabilizer README
  • Subfolder Stabilizer/PSS1A for the existing doc has been partially cleaned but not validated
  • Subfolder Stabilizer/IEEEST with docs which should be the first stabilizer implemented.
  • IEEEST Implementation
  • The exciter and stabilizer can now be wired through the new external variable in IEEET1, vs.
  • Lots of potentially unsafe parameters that are still valid model definitions, so I used a masking method that works with Enzyme. Not sure if it's optimal, but it works with a 240 bus case.

Checklist

  • All tests pass. ( 44 - EnzymePowerElectronicsCheck is failing but that happens for me on development as well)
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

I have an uncommitted GENROU saturation fix and WECC 240 case that are pending this model!

The input signal delay is not implemented and is discussed in #369 . not a blocker

Added README.md for IEEEST model documentation, including model parameters, variables, and equations.
@lukelowry lukelowry requested a review from pelesh April 8, 2026 20:45
@lukelowry lukelowry assigned lukelowry and unassigned lukelowry Apr 8, 2026
@lukelowry lukelowry added the documentation Improvements or additions to documentation label Apr 8, 2026
@lukelowry lukelowry requested a review from abirchfield April 8, 2026 21:02
@lukelowry lukelowry changed the title Stabilizer Docs + IEEEST Documentation Stabilizer Docs + IEEEST Implementation Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@abirchfield abirchfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Two issues with the documentation: the figure on the PSS1A model doesn't show, and the table on the IEEEST model doesn't render correctly on github.

Updated image source path for PSS1A model in README.
Updated the README.md to include model parameters for the IEEEST stabilizer. Not sure why it rendered correctly in VS Code.
@lukelowry
Copy link
Copy Markdown
Collaborator Author

@abirchfield @pelesh Updated! VSCode and GitHub rendering differently is strange.

@abirchfield abirchfield self-requested a review April 15, 2026 20:34
@nkoukpaizan nkoukpaizan merged commit 6afec4b into develop Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation new model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants