Skip to content

SEXS-PTI Exciter Model + GENROU Saturation#373

Merged
nkoukpaizan merged 8 commits intodevelopfrom
lukel/sexspti-dev
Apr 24, 2026
Merged

SEXS-PTI Exciter Model + GENROU Saturation#373
nkoukpaizan merged 8 commits intodevelopfrom
lukel/sexspti-dev

Conversation

@lukelowry
Copy link
Copy Markdown
Collaborator

@lukelowry lukelowry commented Apr 12, 2026

Description

SEXS-PTI Model added; needed for some of the team's requested cases. Also, to validate the cases that depend on this PR, I need to add a temporary initialization routine for saturation. It is not how we should do this, but I simply need a steady-state solution to verify that the cases in question provide meaningful data or can be simulated at all.

Relies on the changes in the exciter and stabilizer input in #365, so PR is to that branch.

Proposed changes

  • SEXS-PTI Exciter Model
  • Temporary iteration in the initialization of GENROU to initialize nonlinear saturation for the steady state.
  • Consistent documentation for windup limits, which are now used identically in three models
  • Dedicated tests for windup/indicator function

Checklist

  • All tests pass. (There is One preexisting error that is happpening in the PowerElectronics module!)
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

Some of the equations regardining the smooth approximation might need to be updated.

This model is simple and widely used. Let's include this and its data format changes, so we don't need to change the cases as much.

@lukelowry lukelowry requested review from abirchfield and pelesh April 12, 2026 15:43
@lukelowry lukelowry changed the title Lukel/sexspti dev SEXS-PTI Exciter Model + GENROU Saturation Apr 12, 2026
@lukelowry lukelowry marked this pull request as ready for review April 20, 2026 17:57
@lukelowry
Copy link
Copy Markdown
Collaborator Author

I thought I set this up so that once #365 was merged, this would point towards the develop branch, but that appears not to have happened. Otherwise ready

@nkoukpaizan nkoukpaizan changed the base branch from lukel/ieeest-dev to develop April 20, 2026 18:50
@lukelowry lukelowry requested a review from nkoukpaizan April 20, 2026 19:27
@nkoukpaizan
Copy link
Copy Markdown
Collaborator

@lukelowry Could you take a look at the failing test? Looks like something flagged by the address sanitizer.

@lukelowry
Copy link
Copy Markdown
Collaborator Author

@nkoukpaizan Thanks for pointing that out. It was an issue with the signals on the new model. All good now, I believe.

Copy link
Copy Markdown
Collaborator

@nkoukpaizan nkoukpaizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good to me. There are a couple of things I'd like to see addressed before merging.

Comment thread GridKit/CommonMath.hpp
Comment thread tests/UnitTests/PhasorDynamics/ExciterSexsPtiTests.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/ExciterSexsPtiTests.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/ExciterSexsPtiTests.hpp Outdated
@lukelowry
Copy link
Copy Markdown
Collaborator Author

I did some further doc cleanup and consistency chores. It's ready for your review again! @nkoukpaizan

Copy link
Copy Markdown
Collaborator

@nkoukpaizan nkoukpaizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work!

@nkoukpaizan nkoukpaizan merged commit 85a1f2b into develop Apr 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants