SEXS-PTI Exciter Model + GENROU Saturation#373
Merged
nkoukpaizan merged 8 commits intodevelopfrom Apr 24, 2026
Merged
Conversation
7 tasks
Collaborator
Author
|
I thought I set this up so that once #365 was merged, this would point towards the develop branch, but that appears not to have happened. Otherwise ready |
Collaborator
|
@lukelowry Could you take a look at the failing test? Looks like something flagged by the address sanitizer. |
2c06815 to
de0f790
Compare
Collaborator
Author
|
@nkoukpaizan Thanks for pointing that out. It was an issue with the signals on the new model. All good now, I believe. |
abirchfield
approved these changes
Apr 23, 2026
nkoukpaizan
reviewed
Apr 23, 2026
Collaborator
nkoukpaizan
left a comment
There was a problem hiding this comment.
This mostly looks good to me. There are a couple of things I'd like to see addressed before merging.
de0f790 to
6f23a3a
Compare
Collaborator
Author
|
I did some further doc cleanup and consistency chores. It's ready for your review again! @nkoukpaizan |
nkoukpaizan
approved these changes
Apr 24, 2026
Collaborator
nkoukpaizan
left a comment
There was a problem hiding this comment.
Looks good to me. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SEXS-PTI Model added; needed for some of the team's requested cases. Also, to validate the cases that depend on this PR, I need to add a temporary initialization routine for saturation. It is not how we should do this, but I simply need a steady-state solution to verify that the cases in question provide meaningful data or can be simulated at all.
Relies on the changes in the exciter and stabilizer input in #365, so PR is to that branch.
Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Some of the equations regardining the smooth approximation might need to be updated.
This model is simple and widely used. Let's include this and its data format changes, so we don't need to change the cases as much.