initial implementation of #150#151
Closed
superwhiskers wants to merge 5 commits intodevelopfrom
Closed
Conversation
superwhiskers
added
documentation
cameronrutherford
approved these changes
Jun 5, 2024
Collaborator
cameronrutherford
left a comment
cameronrutherford
left a comment
There was a problem hiding this comment.
A few minor comments, but I approve.
I am not a regex expert so I did not have a chance to verify that those are correct.
Collaborator
|
Before it is ready for merge, we need to test it on a few representative code snippets to make sure there are no unintended artifacts. |
pelesh
reviewed
Jun 11, 2024
4 tasks
- drop dead code within `CMakeLists.txt` - remove old `.github/workflows/.clang-format` - create new `.clang-format` at the repository root, with settings based on observed patterns & `CONTRIBUTING.md`
…format 16 minimum
pelesh
force-pushed
the
implement-initial-suggestions-from-150
branch
from
8aff4b8 to
b1f6fa2
Compare
9 tasks
Collaborator
Author
|
dropping in favor of #261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request implements the initial suggestions proposed within #150
i'm not going to merge this until some discussion about the formatting options in
.clang-formathas happened, and appropriate modifications have been made toCONTRIBUTING.mdCloses #54
Closes #150