Conversation
nkoukpaizan
force-pushed
the
hykkt-cholesky-fix
branch
from
4c2f2b6 to
7e15eb9
Compare
nkoukpaizan
force-pushed
the
hykkt-cholesky-fix
branch
from
5b58297 to
4c2f2b6
Compare
shakedregev
reviewed
Sep 4, 2025
Collaborator
shakedregev
left a comment
shakedregev
left a comment
There was a problem hiding this comment.
This looks good and the tests pass (still pass on CUDA too). Unfortunately, there are now many merge "conflicts". I think the easiest thing will be to apply your commits from a new branch, since you only changed two files. I will attempt that.
Collaborator
|
It seems like only two files were changed from this other version of the code, but many more things happened. Any insight as to how to do this would be appreciated. |
nkoukpaizan
force-pushed
the
hykkt-cholesky-fix
branch
from
4c2f2b6 to
a6ad65c
Compare
nkoukpaizan
force-pushed
the
hykkt-cholesky-fix
branch
from
a9d1c2e to
4c2f2b6
Compare
7 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #356
Fix is not the cleanest, AMD investigation is ongoing.