Hykkt cholesky fix (rebased)#371
Merged
shakedregev merged 8 commits intohykkt-devfrom Sep 5, 2025
Merged
Conversation
* fixed failing test by resetting workspace * Apply pre-commmit fixes * Update tests/unit/hykkt/runHykktCholeskyTests.cpp * Apply pre-commmit fixes --------- Co-authored-by: shakedregev <shakedregev@users.noreply.github.com>
nkoukpaizan
force-pushed
the
nicholson/hykkt-cholesky-fix
branch
from
1cd5532 to
b1026cb
Compare
shakedregev
approved these changes
Sep 5, 2025
Collaborator
shakedregev
left a comment
shakedregev
left a comment
There was a problem hiding this comment.
Tests are finally being all run and passing.
Closed
shakedregev
added a commit
that referenced
this pull request
Nov 13, 2025
* dependencies * randomized testing: different sparsity patterns * fix for cuda: resetting workspace * Apply pre-commmit fixes * non clean work around -- fixes cholesky test * Fixes after rebasing. * Fixed failing Cholesky test by resetting workspace (#370) * fixed failing test by resetting workspace * Apply pre-commmit fixes * Update tests/unit/hykkt/runHykktCholeskyTests.cpp * Apply pre-commmit fixes --------- Co-authored-by: shakedregev <shakedregev@users.noreply.github.com> * Uncommented Cholesky test on HIP backend, and added syndData calls. --------- Co-authored-by: Adham Ibrahim <adham.ibrahim@princeton.edu> Co-authored-by: adhamsi <adhamsi@users.noreply.github.com> Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com> Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com> Co-authored-by: shakedregev <shakedregev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#368 with a rebased branch and additional bug fixes
Closes #356
Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments