make PendingIntents compatible with Android 12#1400
Closed
AndreasBoehm wants to merge 1 commit intoOneSignal:mainfrom
AndreasBoehm:adjust-pendingintent-flags-for-android12
Closed
make PendingIntents compatible with Android 12#1400AndreasBoehm wants to merge 1 commit intoOneSignal:mainfrom AndreasBoehm:adjust-pendingintent-flags-for-android12
AndreasBoehm wants to merge 1 commit intoOneSignal:mainfrom
AndreasBoehm:adjust-pendingintent-flags-for-android12
Conversation
Member
|
@AndreasBoehm Thanks for the PR. There was a recent change in PR #1377 that moved this logic around. I recreated PR #1411 based on your changes and reference this PR to give you credit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Android 12 forces mutability to be specified when creating a PendingIntent I got a couple of errors in logcat when starting my app targeting Android SDK 31 (Android 12).
https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
This PR fixes those issues on OneSignal side. (#1408)
The be fully compatible we would need to upgrade workmanager to at least
2.7.0-alpha05but I think that we should wait with that until2.7.0is stable.This change is