Android 12 Compatibility - Add pending intent flag immutable#1411
Merged
Android 12 Compatibility - Add pending intent flag immutable#1411
Conversation
* This is a required change for Android 12
* This is a required change for Android 12
jkasten2
deleted the
compat/android12/add_pending_intent_flag_immutable
branch
jkasten2
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Android 12 requires
PendingIntentsto setFLAG_IMMUTABLEhttps://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
This is based on PR #1400, thanks to @AndreasBoehm
PendingIntent.FLAG_IMMUTABLEwas interduce in Android API 23 (android 6.0) but confirmed on Android 4.4 the flag is safely ignored.This change is