[5.0.0] Fix IAM display & dismiss bugs#1799
Merged
emawby merged 1 commit intouser-model/mainfrom Aug 10, 2023
Merged
Conversation
emawby
suggested changes
Aug 9, 2023
| // If there was a message dequeued, display it | ||
| if (messageToDisplay != null) { | ||
| var result = _displayer.displayMessage(messageToDisplay!!) | ||
| _state.inAppMessageIdShowing = null |
Contributor
There was a problem hiding this comment.
If result isn't null or false that means that we are displaying a message correct? In that case setting the id to null seems wrong.
emawby
approved these changes
Aug 10, 2023
Remove return if lifecycleCallback.hasSubscribers is false
Merged
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
[5.0.0] Fix IAM display & dismiss bugs
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
[5.0.0] Fix IAM display & dismiss bugs
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
[5.0.0] Fix IAM display & dismiss bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
This PR addresses two In App Message bugs:
InAppMessagesManager.attemptToShowInAppMessage: There is an IAM currently showing!messageWasDismissedreturning early if!_lifecycleCallback.hasSubscribersDetails
Motivation
Issue 1
Issue is reproducible following these steps:
addTriggermethodInAppMessagesManager.attemptToShowInAppMessage: There is an IAM currently showing!setting
inAppMessageIdShowingback tonullinattemptToShowInAppMessageallows IAM_2 to successfully display.Issue 2
This issue was caught during a pair programming session where the early return would interfere with
_lifecycleCallback.fireOnMainbeing called.Scope
Changes affect displaying and dismissing IAMs, specifically
attemptToShowInAppMessage&messageWasDismissedin InAppMessagesManager.OPTIONAL - Other
OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.
Testing
Manual testing
Tested Issue 1 to ensure that second IAM successfully displays.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is