Skip to content

[5.0.0] Fix IAM display & dismiss bugs #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emawby merged 1 commit into from
Aug 10, 2023
Merged

[5.0.0] Fix IAM display & dismiss bugs #1799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...n-app-messages/src/main/java/com/onesignal/inAppMessages/internal/InAppMessagesManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,11 +393,9 @@ internal class InAppMessagesManager(
}

// fire the external callback
if (!_lifecycleCallback.hasSubscribers) {
Logging.verbose("InAppMessagesManager.messageWasDismissed: inAppMessageLifecycleHandler is null")
return
if (_lifecycleCallback.hasSubscribers) {
_lifecycleCallback.fireOnMain { it.onDidDismiss(InAppMessageLifecycleEvent(message)) }
Comment thread
emawby marked this conversation as resolved.
}
_lifecycleCallback.fireOnMain { it.onDidDismiss(InAppMessageLifecycleEvent(message)) }

_state.inAppMessageIdShowing = null

Expand Down