Skip to content

[CI] v5 - fix setup android step#1958

Closed
nan-li wants to merge 1 commit intomainfrom
ci/fix_setup_android_step
Closed

[CI] v5 - fix setup android step#1958
nan-li wants to merge 1 commit intomainfrom
ci/fix_setup_android_step

Conversation

@nan-li
Copy link
Copy Markdown
Contributor

@nan-li nan-li commented Jan 11, 2024

Description

One Line Summary

Fix failing CI step for setup Android on pull requests, that started failing suddenly.

Details

Out of nowhere, the CI is failing for PRs that was passing just a couple of days ago, on the step for setup Android. Not sure what happened:

build
Unable to locate executable file: /usr/local/lib/android/sdk/tools/bin/sdkmanager. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

Screenshot 2024-01-11 at 11 52 42 AM

Motivation

Motivation:

  • This step started failing recently on PRs.

Solution:

  • Tried first modifying the CI file to use cache: false, but this did not resolve the error.
  • Although we don't know the cause of the sudden failures, let's try android-actions/setup-android instead
  • maxim-lobanov/setup-android-tools hasn't had any updates in 4 years

Scope

CI on PRs

OPTIONAL - Other

OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.

Testing

Unit testing

N/A

Manual testing

  1. Make a small change to code and create PR
  2. See the CI fail
  3. Update the .github/workflows/ci.yml file with the changes in this PR
  4. See the CI now succeed

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li changed the title [CI] fix setup android step [CI] v5 - fix setup android step Jan 11, 2024
Copy link
Copy Markdown
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but looks like we should remove this commit:
dc7fedb

@nan-li nan-li force-pushed the ci/fix_setup_android_step branch from eae2ebe to 73e2915 Compare January 29, 2024 19:43
@nan-li
Copy link
Copy Markdown
Contributor Author

nan-li commented Jan 29, 2024

Looks good to me, but looks like we should remove this commit:
dc7fedb

Cleaned up the commit history

@nan-li nan-li requested a review from jkasten2 January 29, 2024 19:44
@nan-li
Copy link
Copy Markdown
Contributor Author

nan-li commented Jan 29, 2024

These changes resulted in a successful build prior, but looks like the build just failed, after we updated the work runtime dependency to 2.8.1.

1.  Dependency 'androidx.work:work-runtime-ktx:2.8.1' requires libraries and applications that
           depend on it to compile against version 33 or later of the
           Android APIs.
     
           :OneSignal:in-app-messages is currently compiled against android-31.
     
           Also, the maximum recommended compile SDK version for Android Gradle
           plugin 7.2.0 is 32.
     
           Recommended action: Update this project's version of the Android Gradle
           plugin to one that supports 33, then update this project to use
           compileSdkVerion of at least 33.
     
           Note that updating a library or application's compileSdkVersion (which
           allows newer APIs to be used) can be done separately from updating
           targetSdkVersion (which opts the app in to new runtime behavior) and
           minSdkVersion (which determines which devices the app can be installed
           on).

@jinliu9508 jinliu9508 deleted the branch main January 31, 2024 21:21
@jinliu9508 jinliu9508 closed this Jan 31, 2024
@nan-li nan-li reopened this Jan 31, 2024
@jinliu9508 jinliu9508 force-pushed the user-model/main branch 3 times, most recently from 2072eac to d73bfc6 Compare February 6, 2024 16:38
Base automatically changed from user-model/main to main February 6, 2024 18:32
@nan-li nan-li closed this Feb 7, 2024
@nan-li nan-li force-pushed the ci/fix_setup_android_step branch from 73e2915 to 4f2f7ad Compare February 7, 2024 19:41
Motivation:
- This step started failing recently on PRs.

Solution:
- Although we don't know the cause of the sudden failures, let's try `android-actions/setup-android` instead
- `maxim-lobanov/setup-android-tools` hasn't had any updates in 4 years
@nan-li nan-li reopened this Feb 7, 2024
@nan-li
Copy link
Copy Markdown
Contributor Author

nan-li commented Feb 7, 2024

This branch was just rebased on main after merging user model to main. There is a lint failure before reaching the Unit Tests now.

@nan-li
Copy link
Copy Markdown
Contributor Author

nan-li commented Feb 15, 2024

Closing as newer PR #1992 fixes this

@nan-li nan-li closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants