CI - Switch to android-actions/setup-android@v3#1992
Merged
Conversation
maxim-lobanov/setup-android-tools is no longer working with github CI and it hasn't been updated in 4 years.
This is required for the newer Android command line tools being used now. Also dropped installing gradle, gradlew already handles this.
nan-li
approved these changes
Feb 14, 2024
This was referenced Feb 15, 2024
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
maxim-lobanov/setup-android-toolsis no longer working with github CI, replacing it withandroid-actions/setup-android@v3.Details
Setup
android-actions/setup-android@v3to use the latest Android command line tools it currently supports 10406996. Disabled printing Android licenses vialog-accepted-android-sdk-licenses: falseto keep our logs small.Also update CI from Java 11 -> 17, as the new Android SDK tools require it.
Thanks to the work @nan-li did in PR #1958 which this PR is based on.
Motivation
maxim-lobanov/setup-android-toolsis no longer working with github CI and it hasn't been updated in 4 years.Scope
Only updating Android SDK dependencies to get the CI past the setup failing.
Testing
Unit testing
Ensured CI test now gets past the Android setup phase. (linting is still failing but, will be addressed in a follow up PR)
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is