Skip to content

CI - Switch to android-actions/setup-android@v3#1992

Merged
jkasten2 merged 2 commits intomainfrom
ci/upgrade-android-tools-and-sdk-to-10406996
Feb 15, 2024
Merged

CI - Switch to android-actions/setup-android@v3#1992
jkasten2 merged 2 commits intomainfrom
ci/upgrade-android-tools-and-sdk-to-10406996

Conversation

@jkasten2
Copy link
Copy Markdown
Member

@jkasten2 jkasten2 commented Feb 14, 2024

Description

One Line Summary

maxim-lobanov/setup-android-tools is no longer working with github CI, replacing it with android-actions/setup-android@v3.

Details

Setup android-actions/setup-android@v3 to use the latest Android command line tools it currently supports 10406996. Disabled printing Android licenses via log-accepted-android-sdk-licenses: false to keep our logs small.
Also update CI from Java 11 -> 17, as the new Android SDK tools require it.

Thanks to the work @nan-li did in PR #1958 which this PR is based on.

Motivation

maxim-lobanov/setup-android-tools is no longer working with github CI and it hasn't been updated in 4 years.

Scope

Only updating Android SDK dependencies to get the CI past the setup failing.

  • Linting, unit test failures, and other step fixes will be addressed in follow up PRs.

Testing

Unit testing

Ensured CI test now gets past the Android setup phase. (linting is still failing but, will be addressed in a follow up PR)

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
    • Out of scope of this PR to fix lint errors.
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

maxim-lobanov/setup-android-tools is no longer working with github CI
and it hasn't been updated in 4 years.
This is required for the newer Android command line tools being used
now. Also dropped installing gradle, gradlew already handles this.
@jkasten2 jkasten2 requested a review from nan-li February 14, 2024 21:53
@jkasten2 jkasten2 changed the title WIP - CI - switch CI to use android-actions/setup-android@v3 CI - Switch CI to use android-actions/setup-android@v3 Feb 14, 2024
@jkasten2 jkasten2 changed the title CI - Switch CI to use android-actions/setup-android@v3 CI - Switch to android-actions/setup-android@v3 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants