[Fix] Xiaomi notification click not foregrounding app#2129
Merged
Conversation
This fixes a bug where tapping on a OneSignal notification on a Xiaomi device doesn't bring the app to the foreground. Xiaomi has very strict activity trampolining rules on notification open. We have to start the next activity before the current activity is finished. Tested on Xiaomi Redmi 6A device with MIUI 11.0.8 (Android 9) as well as an Android 14 emulator.
nan-li
approved these changes
Jun 18, 2024
Contributor
nan-li
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @emawby, @jennantilla, @jinliu9508, and @shepherd-l)
jinliu9508
approved these changes
Jun 18, 2024
Merged
This was referenced Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes a bug where tapping on a OneSignal notification on a Xiaomi device doesn't bring the app to the foreground.
Details
Xiaomi has very strict activity trampolining rules on notification open. We have to start the next activity before the current activity is finished.
Motivation
Xiaomi devices are commonly used so it is important notifications open behaves correctly.
Scope
Delays when the invisible activity is closed.
Related
Testing
Manual testing
Tested on Xiaomi Redmi 6A device with MIUI 11.0.8 (Android 9) as well as an Android 14 emulator with the following scenarios:
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is