Skip to content

[Fix] Xiaomi notification click not foregrounding app #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkasten2 merged 1 commit into from
Jun 18, 2024
Merged

[Fix] Xiaomi notification click not foregrounding app #2129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions ...ns/src/main/java/com/onesignal/notifications/activities/NotificationOpenedActivityBase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,32 +36,26 @@ import com.onesignal.notifications.internal.open.INotificationOpenedProcessor
abstract class NotificationOpenedActivityBase : Activity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
if (!OneSignal.initWithContext(applicationContext)) {
return
}

var self = this

suspendifyOnThread {
var openedProcessor = OneSignal.getService<INotificationOpenedProcessor>()
openedProcessor.processFromContext(self, intent)
}

finish()
processIntent()
}

override fun onNewIntent(intent: Intent) {
super.onNewIntent(intent)
processIntent()
}

private fun processIntent() {
if (!OneSignal.initWithContext(applicationContext)) {
return
}

var self = this
suspendifyOnThread {
var openedProcessor = OneSignal.getService<INotificationOpenedProcessor>()
openedProcessor.processFromContext(self, getIntent())
val openedProcessor = OneSignal.getService<INotificationOpenedProcessor>()
openedProcessor.processFromContext(this, intent)
Comment thread
jinliu9508 marked this conversation as resolved.
// KEEP: Xiaomi Compatibility:
// Must keep this Activity alive while trampolining, that is
// startActivity() must be called BEFORE finish(), otherwise
// the app is never foregrounded.
finish()
}

finish()
}
}