feat: add custom events support#153
Merged
fadi-george merged 3 commits intomainfrom Feb 9, 2026
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> | ||
| <TargetFrameworks>net7.0-android</TargetFrameworks> | ||
| <TargetFrameworks>net8.0-android;net9.0-android;net10.0-android</TargetFrameworks> |
There was a problem hiding this comment.
is it safe the upgrade the framework like this?
Contributor
Author
There was a problem hiding this comment.
@abdulraqeeb33 https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core
7 is EoL, net8-9 will expire this year
There was a problem hiding this comment.
hmm, but whats the impact of upgrading? would customers need to do anything on their side?
Contributor
Author
There was a problem hiding this comment.
I expect developers to use dotnet8 (have it installed) or later which should be the case since 7 is EoL
Contributor
Author
There was a problem hiding this comment.
Josh said it doesn't need to be a breaking change.
fadi-george
force-pushed
the
fg/custom-events
branch
from
294161a to
86fbd58
Compare
abdulraqeeb33
approved these changes
Feb 9, 2026
abdulraqeeb33
left a comment
abdulraqeeb33
left a comment
There was a problem hiding this comment.
looks good to me at a high level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Dashboard Logs
Example Apps
Details
iOSUserManager.csandAndroidUserManager.csToNativeConversionas java side expects a map typeTrack Eventbutton for testing the custom events logicMotivation
Want to add custom events support for all the SDKs.
Manual testing
See screenshot of the dashboard custom events log. Has all the complex property values (for ios and android) and with/without props.
Affected code checklist
Checklist
Overview
Testing
Final pass