Skip to content

Add missing fallbackToSettings argument on native iOS side#523

Merged
jkasten2 merged 1 commit intoOneSignal:mainfrom
slawekkrol:main
Mar 2, 2022
Merged

Add missing fallbackToSettings argument on native iOS side#523
jkasten2 merged 1 commit intoOneSignal:mainfrom
slawekkrol:main

Conversation

@slawekkrol
Copy link
Copy Markdown
Contributor

@slawekkrol slawekkrol commented Jan 11, 2022

This change is Reviewable

Copy link
Copy Markdown
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slawekkrol Thanks for the PR, the code changes themselves looks like it will work. Can you note the iOS version and Flutter version you have tested this on?

@nan-li nan-li self-requested a review January 11, 2022 19:16
@slawekkrol
Copy link
Copy Markdown
Contributor Author

@slawekkrol Thanks for the PR, the code changes themselves looks like it will work. Can you note the iOS version and Flutter version you have tested this on?

Flutter 2.5.3 • channel stable
Tools • Dart 2.14.4
iOS 15.2

But IMO this really doesn't matter because this change is only native ObjC code in one place, so this code must works on every version iOS and flutter

Copy link
Copy Markdown
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing those details.

@jkasten2 jkasten2 requested a review from tanaynigam February 25, 2022 20:05
Copy link
Copy Markdown
Contributor

@tanaynigam tanaynigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nan-li)

@jkasten2 jkasten2 merged commit 6ddc347 into OneSignal:main Mar 2, 2022
nan-li added a commit that referenced this pull request Mar 10, 2022
@nan-li nan-li mentioned this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants