Merged
Conversation
jkasten2
approved these changes
Mar 10, 2022
Member
jkasten2
left a comment
There was a problem hiding this comment.
One nit on a log level, feel free to fix and merge without another approval from my end.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emawby, @Jeasmine, and @nan-li)
lib/onesignal_flutter.dart, line 176 at r1 (raw file):
"OneSignal#setLaunchURLsInApp", {'isEnabled': isEnabled}); } else { _onesignalLog(OSLogLevel.verbose,
nit, I would say this should be info instead of verbose.
9f9a0e1 to
841c204
Compare
nan-li
added a commit
that referenced
this pull request
Mar 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds the
setLaunchURLsInAppfunction that is for iOS only.Details
The function, previously only available via the native iOS SDK, does the following:
For Android, just log that it is unsupported and don't add to plugin.
setLaunchURLsInAppmethod to OneSignal iOS pluginsetLaunchURLsInAppbridge method to onesignal_flutter.dartsetLaunchURLsInAppmethod to the example app withfalseTest
setLaunchURLsInAppwithtrueandfalse. Tested with OneSignal-iOS-SDK 3.10.1 that remedied the problem with calling after init.This change is