Add 4 privacy manifests for the 4 importable targets#1334
Merged
Conversation
In each of the following targets: - OneSignalExtension - OneSignalFramework - OneSignalInAppMessaging - OneSignalLocation
emawby
approved these changes
Nov 29, 2023
Contributor
Author
|
Have not heard responses yet for forum post or email correspondence. |
This was referenced Dec 1, 2023
Merged
1 task
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add privacy manifests to Framework, Extension, InAppMessaging, and Location by following Apple documentation.
Details
Adds a privacy manifest to each of the following targets:
Currently, they are not added to the other targets such as Core, Outcomes, User, etc. as these targets are already accounted for by inclusion in the umbrella
OneSignalFrameworktarget. App developers do not import these smaller modules directly but only viaOneSignalFramework.We will await feedback if the above is true and these "sub-modules" don't need a privacy manifest.
🚧 Remaining questions
For the Data Collected category (see Apple docs), I have chosen
Analyticsas the reason for most as this is the level that OneSignal uses the data for, and that the data is not linked to user identity (as this is the minimum use case to account for anonymous users if the SDK consumer is not using any identifiers). However, apps can use this data for different reasons.In addition, I have not submitted other data such as email or phone numbers as the SDK is capable of collecting these but only if the app developer chooses.
See https://developer.apple.com/forums/thread/738710
Motivation
Third-party privacy manifests will be required by Apple.
Scope
Privacy manifest
OneSignalLocation
OneSignalInAppMessaging
NSPrivacyAccessedAPICategoryUserDefaultsfor reasonCA92.1(docs)OneSignalExtension
NSPrivacyAccessedAPICategoryUserDefaultsfor reasonCA92.1(docs)OneSignalFramework
NSPrivacyAccessedAPICategoryUserDefaultsfor reasonCA92.1(docs)Testing
Unit testing
None
Manual testing
None
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is