Add additional 6 privacy manifests to the 6 sub-targets#1431
Merged
Conversation
* In each of the following targets that aren't imported on their own but are included in the primary targets. * For completeness, we also provide a privacy manifest for each of these. - OneSignalUser - OneSignalNotifications - OneSignalLiveActivities - OneSignalOutcomes - OneSignalOSCore - OneSignalCore
6886b02 to
1c5d7e8
Compare
emawby
approved these changes
May 10, 2024
This was referenced May 10, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add additional privacy manifests to User, Notifications, LiveActivities, Outcomes, OSCore, and Core by following Apple documentation.
Details
In #1334 we added Privacy Manifest to the 4 targets that clients would import.
There was this comment in the PR:
We haven't received concrete information on the last question, but since that PR, Apple has released a list of SDKs that require a privacy manifest and signature and listed the following player model SDKs, leading me to believe they do detect every sub target?
Motivation
Third-party privacy manifests required by Apple.
Scope
Privacy Manifests
Testing
Unit testing
None
Manual testing
Build and archive app, inspect the Privacy Report
See the generated report for the example app OneSignalExample-PrivacyReport.pdf
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is