Add OneSignal-Subscription-Id to Create User request#1372
Merged
Conversation
- This was an ask of the SDK to support improved `last_active` tracking subscriptions that were actually active - Moved the helper method to add this header out of User Update so it can be accessed also by Create User
* In the preparation step for a User Update request, adding the push subscription ID header was actually blocking if it is not available. * This probably shouldn't block updates.
jkasten2
approved these changes
Feb 22, 2024
Contributor
Author
|
Just tested today with server changes completed that |
This was referenced Mar 5, 2024
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add the
OneSignal-Subscription-Idheader to Create User requests.Details
Motivation
last_activetracking subscriptions that were actually activelast_activeupdated.Scope
last_activeupdated.Testing
Unit testing
None, we can add in future to make sure headers are included.
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is