Skip to content

Release 5.1.2#78

Closed
nan-li wants to merge 1 commit intomajor_release_5.0.0from
rel/5.1.2
Closed

Release 5.1.2#78
nan-li wants to merge 1 commit intomajor_release_5.0.0from
rel/5.1.2

Conversation

@nan-li
Copy link
Copy Markdown
Contributor

@nan-li nan-li commented Mar 6, 2024

What's Changed

⚠️ Behavior Changes

  • When you call the jsonRepresentation method of OSPushSubscriptionState, if a property is null, the value will now be "" instead of the string literal "nil" #1373

🐛 Bug Fixes & Misc Improvements

  • Rename internal method that was called setSharedInstance to workaround false App Store flagging #1375
  • Improve Swift concurrency safety to address crash reports in production #1376
  • For our server: Add OneSignal-Subscription-Id to Create User request which improves last_active data #1372

This change is Reviewable

@nan-li
Copy link
Copy Markdown
Contributor Author

nan-li commented Mar 6, 2024

Our released version 5.1.1 causes a build error for users.
This is the same codebase as v5.1.1

@nan-li nan-li requested review from emawby and jkasten2 March 6, 2024 18:05
@nan-li
Copy link
Copy Markdown
Contributor Author

nan-li commented Mar 6, 2024

5.1.2 also caused the same issues, it was released manually but the problem was not in the release process.

@nan-li nan-li closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant