Skip to content

Rename internal method to workaround false App Store flagging#1375

Merged
nan-li merged 1 commit intomainfrom
rename_app_store_flagged_method
Mar 4, 2024
Merged

Rename internal method to workaround false App Store flagging#1375
nan-li merged 1 commit intomainfrom
rename_app_store_flagged_method

Conversation

@nan-li
Copy link
Copy Markdown
Contributor

@nan-li nan-li commented Feb 22, 2024

Description

One Line Summary

Rename an internal method setSharedInstance to setSharedOSDialogInstance due to App Store Connect rejecting builds with the previous method name.

Details

  • App Store Connect is flagging our method setSharedInstance in a false negative manner
  • New 5.1.0 #1374 says changing this method name they were able to successfully submit the build.

Motivation

Scope

Just a rename of internal method, no implementation changes

Testing

Manual testing

App builds and runs

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

* App Store Connect is flagging our method `setSharedInstance` in a false negative manner
*  Error states: Asset validation failed... The app references non-public selectors in Payload/Runner.app/Frameworks/OneSignalFramework.framework/OneSignalFramework: setSharedInstance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants