Rename internal method to workaround false App Store flagging#1375
Merged
Rename internal method to workaround false App Store flagging#1375
Conversation
* App Store Connect is flagging our method `setSharedInstance` in a false negative manner * Error states: Asset validation failed... The app references non-public selectors in Payload/Runner.app/Frameworks/OneSignalFramework.framework/OneSignalFramework: setSharedInstance
emawby
approved these changes
Mar 4, 2024
This was referenced Mar 5, 2024
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Rename an internal method
setSharedInstancetosetSharedOSDialogInstancedue to App Store Connect rejecting builds with the previous method name.Details
setSharedInstancein a false negative mannerMotivation
Scope
Just a rename of internal method, no implementation changes
Testing
Manual testing
App builds and runs
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is