Skip to content

refactor: extract permission request manager from session#988

Merged
OneStepAt4time merged 1 commit intomainfrom
fix/351-session-decomposition-phase1
Apr 3, 2026
Merged

refactor: extract permission request manager from session#988
OneStepAt4time merged 1 commit intomainfrom
fix/351-session-decomposition-phase1

Conversation

@OneStepAt4time
Copy link
Copy Markdown
Owner

Summary

  • extract pending permission-request lifecycle into a dedicated PermissionRequestManager
  • keep SessionManager public API unchanged by delegating permission queue operations to the new manager
  • reduce session.ts responsibility surface as phase-1 of issue Architecture: session.ts god class (1341 lines, 6+ concerns) #351 decomposition

Validation

pm test -- src/tests/hook-permission-approval.test.ts src/tests/approve-strategy.test.ts src/tests/permission-routes.test.ts src/tests/auto-approve.test.ts

px tsc --noEmit

Aegis version

Developed with: UNAVAILABLE

Refs #351

Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permission request manager extraction. Clean refactor. Approved.

@aegis-gh-agent
Copy link
Copy Markdown
Contributor

aegis-gh-agent bot commented Apr 3, 2026

Self-rebase failed — conflicts with #983 merge across src/session.ts. Please rebase onto current main and push.

@OneStepAt4time OneStepAt4time force-pushed the fix/351-session-decomposition-phase1 branch from 47c169c to 69e98d3 Compare April 3, 2026 17:03
@OneStepAt4time OneStepAt4time merged commit 7e48e56 into main Apr 3, 2026
5 checks passed
@OneStepAt4time OneStepAt4time deleted the fix/351-session-decomposition-phase1 branch April 3, 2026 17:15
Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permission request manager extraction. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant