Skip to content

refactor: extract question lifecycle manager from session#993

Merged
OneStepAt4time merged 1 commit intomainfrom
fix/351-session-decomposition-phase2
Apr 3, 2026
Merged

refactor: extract question lifecycle manager from session#993
OneStepAt4time merged 1 commit intomainfrom
fix/351-session-decomposition-phase2

Conversation

@OneStepAt4time
Copy link
Copy Markdown
Owner

Summary

  • extract pending question lifecycle from session.ts into QuestionManager
  • preserve SessionManager public API (no breaking changes)
  • simplify session.ts further for Phase 2 goal
  • add unit tests for QuestionManager behavior

Validation

  • npx tsc --noEmit
  • npm test
  • npm run build

Aegis version

Developed with: v2.10.1

Closes #351 (phase 2)

Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuestionManager extraction. Clean phase 2 refactor. Approved.

@aegis-gh-agent
Copy link
Copy Markdown
Contributor

aegis-gh-agent bot commented Apr 3, 2026

Self-rebase failed — conflicts with #991 (telegram.ts) and #988 (session.ts). Please rebase onto current main. Approved — will merge immediately on green CI.

@OneStepAt4time OneStepAt4time force-pushed the fix/351-session-decomposition-phase2 branch from 7814ca1 to 35f7a30 Compare April 3, 2026 18:18
Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuestionManager extraction phase 2. Approved.

Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuestionManager extraction. Approved.

@aegis-gh-agent
Copy link
Copy Markdown
Contributor

aegis-gh-agent bot commented Apr 3, 2026

Self-rebase impossible — 16+ conflicts across release files, dashboard files, session.ts. Please rebase onto current main. Approved — will merge on green CI.

Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuestionManager extraction phase 2. Approved.

@OneStepAt4time OneStepAt4time force-pushed the fix/351-session-decomposition-phase2 branch from 35f7a30 to 990317d Compare April 3, 2026 18:44
@OneStepAt4time OneStepAt4time merged commit fd2db65 into main Apr 3, 2026
5 checks passed
@OneStepAt4time OneStepAt4time deleted the fix/351-session-decomposition-phase2 branch April 3, 2026 18:58
Copy link
Copy Markdown
Contributor

@aegis-gh-agent aegis-gh-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuestionManager extraction phase 2. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Architecture: session.ts god class (1341 lines, 6+ concerns)

1 participant