refactor: telegram.ts monolith — extract tgApi, remove duplicate esc/bold/code/italic, add backoff#991
Merged
OneStepAt4time merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
…te esc/bold/code/italic, add backoff Fixes #352: - Converted standalone tgApi() to private instance method (removes global rateLimitUntil) - Removed duplicate HTML escaping functions (esc, bold, code, italic) — now using telegram-style.ts imports directly - Added exponential backoff to pollLoop errors (1s → 2s → 4s → 8s → 16s → max 30s) - Added pollBackoffMs instance variable for graceful error recovery This resolves test isolation issues and removes ~60 lines of dead duplicated code.
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #352 — TelegramChannel monolith refactor.
Changes
Converted tgApi() to private instance method — removed global rateLimitUntil variable, now instance state. Fixes multi-instance and test isolation issues.
Removed duplicate HTML escaping functions — esc(), bold(), code(), italic() were defined identically in both telegram.ts and telegram-style.ts. Now using the telegram-style.ts imports directly.
Added exponential backoff to pollLoop — errors now back off exponentially (1s → 2s → 4s → 8s → 16s → max 30s) instead of fixed 5s sleep. Resets on successful response.
Added pollBackoffMs instance variable — tracks current backoff state for graceful error recovery.
Test Plan
Developed with: v2.9.3
Tested with: v2.9.3