Skip to content

useSingleRequestParameter should mark parameter optional if all properties are optional#11135

Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom
davidgamero:davidgamero/node-fetch-single-param-optional
Dec 24, 2021
Merged

useSingleRequestParameter should mark parameter optional if all properties are optional#11135
macjohnny merged 2 commits intoOpenAPITools:masterfrom
davidgamero:davidgamero/node-fetch-single-param-optional

Conversation

@davidgamero
Copy link
Contributor

@davidgamero davidgamero commented Dec 15, 2021

This PR uses a default value to requestParameters (= {}) if all the parameters are optional.

Fixes #11112

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

Copy link
Contributor

@amakhrov amakhrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Looks great (and I even feel other TS generators would benefit from a similar change, too).

@davidgamero
Copy link
Contributor Author

Thank you! Just need a maintainer approval to run workflow next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-fetch] useSingleRequestParameter should mark parameter optional if all properties are optional

4 participants