[typescript] Default auth method support and optional param object when all params optional#11321
Merged
TiFu merged 23 commits intoOpenAPITools:masterfrom Jan 22, 2022
Merged
Conversation
Contributor
Author
|
I'm happy to split this into two separate PR's if this is too messy btw |
TiFu
requested changes
Jan 15, 2022
Contributor
TiFu
left a comment
There was a problem hiding this comment.
Thank you for the pull request! :)
I think we can keep it as 1 PR - it's not messy at all and quite easy to read & understand.
Added a couple comments with questions and a small change.
samples/openapi3/client/petstore/typescript/builds/default/types/ObjectParamAPI.ts
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript/api/api.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript/api/api.mustache
Outdated
Show resolved
Hide resolved
Contributor
Author
|
i've moved the |
Contributor
Author
|
ive excluded the inversify portion since the injection was essentially a whole separate feature |
|
Really looking forward to this change 😄. |
TiFu
approved these changes
Jan 22, 2022
Contributor
|
LGTM! Many thanks for the PR! :) |
This was referenced Jan 25, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
default?: SecurityAuthenticationfield to theAuthMethodsConfigurationtype that populates a similarly typed optional field on theAuthMethodstype.This enables passing a custom object satisfying the
SecurityAuthenticationinterface for authentication purposes in the config either when a client is created or overriding at api call time via config param.Also carry over optional singleParameter when all params optional from here
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov